After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 540488 - Cosmetic error on Gnome Documentation library page
Cosmetic error on Gnome Documentation library page
Status: RESOLVED FIXED
Product: gnome-doc-utils
Classification: Deprecated
Component: docbook xslt
CVS HEAD
Other Windows
: Normal normal
: ---
Assigned To: gnome-doc-utils maintainers
gnome-doc-utils maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-27 13:24 UTC by Marcin Dec
Modified: 2008-06-27 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Marcin Dec 2008-06-27 13:24:21 UTC
There is error on page: http://library.gnome.org/devel/platform-overview/unstable/index.html.en

In "header area", in line just before this blue table with contents.

Regards, Marcin Dec
Comment 1 Frederic Peters 2008-06-27 13:25:45 UTC
Are you talking about "book.label" in "book.labelOverview of the GNOME Platform"?
Comment 2 Marcin Dec 2008-06-27 13:27:30 UTC
(In reply to comment #1)
> Are you talking about "book.label" in "book.labelOverview of the GNOME
> Platform"?

Bingo! :)
Comment 3 Marcin Dec 2008-06-27 13:31:45 UTC
I mean: yes, I'm talking about this "book.label" words. I think there should be link "Overview of the GNOME Platform" adjusted to the right.
Comment 4 Frederic Peters 2008-06-27 14:41:47 UTC
Okay, gnome-doc-utils bug; I added a workaround.

docbook/common/db-label.xsl has:

<!-- = db.label.mode % book = -->
<xsl:template mode="db.label.mode" match="book">
  <xsl:param name="role"/>
  <xsl:call-template name="l10n.gettext">
    <xsl:with-param name="msgid" select="'book.label'"/>
    <xsl:with-param name="role" select="$role"/>
    <xsl:with-param name="node" select="."/>
    <xsl:with-param name="format" select="true()"/>
  </xsl:call-template>
</xsl:template>

but 'book.label' is not a msgid defined in gettext/l10n.xml
Comment 5 Shaun McCance 2008-06-27 16:17:35 UTC
That particular code should never even be called.  With the workaround, you're still getting the title repeated, which is just wrong (although better than the ugliness that is book.label).

The crux of the problem is this:

<xsl:param name="title_node"
 select="($node/title | $info/title)[last()]"/>

This assumes that a title element comes after the *info element.  For everything but books, this is true.  But for some reason, in DocBook, title precedes bookinfo/title.  The result is that bookinfo/title is taken to be the title, then the code that processes non-title (and non-a-few-other-things) blocks later on fails to skip the title element.

The same problem exists with subtitle_node.  I'm trying to figure out the best way of fixing this.
Comment 6 Shaun McCance 2008-06-27 16:24:48 UTC
OK, fixed by explicitly setting the title_node and subtitle_node parameters in the matched template for book elements.