After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 540356 - Problem with NetworkManager interaction
Problem with NetworkManager interaction
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2008-06-26 18:29 UTC by Marco Pesenti Gritti
Modified: 2008-08-14 07:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remember states set when we are disconnected (324 bytes, patch)
2008-06-26 18:37 UTC, Marco Pesenti Gritti
reviewed Details | Review

Description Marco Pesenti Gritti 2008-06-26 18:29:02 UTC
To reproduce:

1 Make sure mission-control is not running
2 Unselect the "Enable wireless" checkbox in the NetworkManager applet
3 Start empathy
4 Select the "Enable wireless" checkbox in the NetworkManager applet

-> empathy is offline, and not available as expected

We are running into this in OnlineDesktop where we start empathy through gnome-session (and so often before NetworkManager is connected)
Comment 1 Marco Pesenti Gritti 2008-06-26 18:31:13 UTC
The problem is that empathy.c calls empathy_idle_set_state (idle, MC_PRESENCE_AVAILABLE); while network manager is not connected, so it gets ignored.
Comment 2 Marco Pesenti Gritti 2008-06-26 18:37:54 UTC
Created attachment 113479 [details] [review]
Remember states set when we are disconnected

I attached a patch that fixes this problem by saving the state in set_presence, if we are disconnected from NetworkManager. I can't think of any bad side effect, but then that code is very complicated and I could be very well missing something.
Comment 3 Xavier Claessens 2008-07-03 22:28:26 UTC
This patch is not enough, there is complex cases with interaction of auto-away feature. I made a more complete rework of that code in my idle-rework git branch:
http://git.collabora.co.uk/?p=user/xclaesse/empathy.git;a=shortlog;h=refs/heads/idle-reworked
Comment 4 Marco Pesenti Gritti 2008-07-17 14:31:33 UTC
Thanks. When is this planned to land on the trunk?
Comment 5 Xavier Claessens 2008-07-17 17:10:02 UTC
When it's reviewed
Comment 6 Xavier Claessens 2008-08-14 07:54:52 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.