After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 540178 - Cover art timeout should not be 20s, but more like 5s.
Cover art timeout should not be 20s, but more like 5s.
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Metadata
git master
Other Linux
: Normal normal
: 1.4.2
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-25 16:08 UTC by Peter de Kraker
Modified: 2009-01-13 22:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change from 20s to 5s in timeout in the MetaDataServiceJob GetHttpStream method (675 bytes, patch)
2008-06-25 16:08 UTC, Peter de Kraker 		none Details | Review

Description Peter de Kraker 2008-06-25 16:08:01 UTC 
Currently the lastfm servers are having some trouble serving their coverart images. This results in waiting 20s for every single album that needs coverart, which is highly annoying.

A timeout for more than 5s should be unnecessary, if the server is always that slow in responding at all it, does more harm then good implementing a provider for it.

But if 5s is to low in your opinion, please at max make it 10s.
Comment 1 Peter de Kraker 2008-06-25 16:08:56 UTC 
Created attachment 113404 [details] [review]
Change from 20s to 5s in timeout in the MetaDataServiceJob GetHttpStream method
Comment 2 Peter de Kraker 2008-06-25 17:25:38 UTC 
FYI: The reference to coverart from lastfm applies to the lastfm metadata provider, which is not (yet) included in Banshee. I am not talking about the lastfm radio or other plugins.

The mentioned timeout value applies to all the metadata providers: musicbrainz, rhapsody, and future ones.
Comment 3 Gabriel Burt 2009-01-13 22:11:34 UTC 
Committed to 10s, thanks Peter.