After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 540172 - The --hide command line parameter isn't working
The --hide command line parameter isn't working
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
1.0.0
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 549576 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-06-25 15:30 UTC by Jan
Modified: 2009-02-25 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
first iteration (1.01 KB, patch)
2009-02-20 11:04 UTC, Alexander Kojevnikov
none Details | Review

Description Jan 2008-06-25 15:30:51 UTC
I have tryed to start banshee direct in tray, without any gui.
The commandline parameter is ignored and the gui starts as normal.
Comment 1 Bertrand Lorentz 2008-06-25 21:06:16 UTC
Starting banshee with only the "--hide" parameter has no effect. I'm not sure it's supposed to have any.

If banshee is already running, launching "banshee-1 --hide" seems to hide the window but it re-appears immediately (it just flickers).
Comment 2 James Mason 2008-07-22 19:39:52 UTC
ditto for --no-present 
Comment 3 Bertrand Lorentz 2008-08-27 19:11:40 UTC
*** Bug 549576 has been marked as a duplicate of this bug. ***
Comment 4 Mateusz Barucha 2008-11-19 21:58:22 UTC
Confirming in 1.4.1. Those arguments still have no effect beside window flickering.
Comment 5 Mateusz Barucha 2009-01-24 17:29:55 UTC
I've recently changed my wallpaper to a motivational one ("Do your work. Don't be stupid." - see http://interfacelift.com/wallpaper/details.php?id=1223 ), but having Banshee automatically started right after login makes the wallpaper invisible after launching the machine. I hope this bug will be squashed soon :)
Comment 6 Alexander Kojevnikov 2009-02-20 11:04:46 UTC
Created attachment 129137 [details] [review]
first iteration

This patch partially fixes the bug:

If Banshee already runs, starting it with "hide" or "no-present" now hides the window. 

However, if it's not running, both arguments have no effect. I'm not sure how to fix it in this case, I will appreciate any pointers.

Basically, I need to get the main window at startup and hide it. When Banshee is not running, the window is returned using:

IClientWindow window = DBusServiceManager.FindInstance<IClientWindow> ("/ClientWindow");

This is called from src/Clients/Halie/Halie/Client.cs:Client.HandleWindowCommands(). I'm not sure what the equivalent would be for the Nereid client.
Comment 7 Gabriel Burt 2009-02-25 16:34:55 UTC
I don't think calling window.Hide () is appropriate for the "no-present" command.  This patch doesn't do anything else, does it?
Comment 8 Mateusz Barucha 2009-02-25 18:13:33 UTC
> Basically, I need to get the main window at startup and hide it.

If it can't be done, maybe it would be better to set a flag somewhere and use it in a place the window is shown for the first time?
Comment 9 Gabriel Burt 2009-02-25 18:22:21 UTC
I have a patch almost ready to fix --hide --present, including at startup.
Comment 10 Gabriel Burt 2009-02-25 18:32:24 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.