After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 540047 - glib-genmarshal.c: '#include <io.h>' is too before.
glib-genmarshal.c: '#include <io.h>' is too before.
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
2.17.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-win32 maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-24 21:50 UTC by Kazuki Iwamoto
Modified: 2008-06-27 10:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for latest glib-genmarshal.c (441 bytes, patch)
2008-06-26 19:29 UTC, Kazuki Iwamoto 		committed Details | Review

Description Kazuki Iwamoto 2008-06-24 21:50:42 UTC 
Please describe the problem:
If G_OS_WIN32 is defined, io.h will be included.
But '#include <io.h>' is before the definition of G_OS_WIN32.
So io.h is never included.

Steps to reproduce:
1. compile glib-genmarshal.c


Actual results:
Following messages are displayed.(Visual C++)
glib-genmarshal.c(666) : error C4013: 'dup' undefined; assuming extern returning int
glib-genmarshal.c(668) : error C4013: 'open' undefined; assuming extern returning int
glib-genmarshal.c(740) : error C4013: 'close' undefined; assuming extern returning int

Expected results:
'#include <io.h>' should be moved after '#include <glib.h>'.


Does this happen every time?
Revision 7089

Other information:
Comment 1 Kazuki Iwamoto 2008-06-26 19:29:18 UTC 
Created attachment 113484 [details] [review]
patch for latest glib-genmarshal.c
Comment 2 Hans Breuer 2008-06-27 10:00:45 UTC 
Fix commited to SVN:

2008-06-27  Hans Breuer  <hans@breuer.org>

	* glib-genmarshal.c : move G_OS_WIN32 inclusion of <io.h> down to
	where G_OS_WIN32 will be defined (#540047, Kazuki IWAMOTO)