After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 539817 - More gstreamer binding fixes
More gstreamer binding fixes
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
0.3.x
Other All
: Normal normal
: ---
Assigned To: Jürg Billeter
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-23 20:19 UTC by Zeeshan Ali
Modified: 2009-03-17 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
More gstreamer binding fixes (1.03 KB, patch)
2008-06-23 20:20 UTC, Zeeshan Ali
committed Details | Review
Corrections for gst_element_make_from_uri(). (1.05 KB, patch)
2008-12-17 15:20 UTC, Zeeshan Ali
committed Details | Review
Regenerate the gstreamer-0.10 vapi. (5.42 KB, patch)
2008-12-17 15:20 UTC, Zeeshan Ali
committed Details | Review
gst_element_get_static_pad returns a ref (1.01 KB, patch)
2008-12-28 00:57 UTC, Zeeshan Ali
none Details | Review
Correct binding for gst_element_get_static_pad(). (1.03 KB, patch)
2008-12-28 01:03 UTC, Zeeshan Ali
committed Details | Review
Fixes to Gst.Registry bindings. (1.60 KB, patch)
2008-12-29 00:12 UTC, Zeeshan Ali
committed Details | Review
Minor fixes to gst_parse*() bindings. (1.10 KB, patch)
2009-01-03 01:39 UTC, Zeeshan Ali
committed Details | Review
fixes parameter in public bool parse_file (uchar[] fname, uchar[] root); (974 bytes, patch)
2009-02-04 12:30 UTC, vasaka
none Details | Review
fixes some method declarations of Gst.XML methods (1.78 KB, patch)
2009-02-05 01:29 UTC, vasaka
none Details | Review
fixes some method declarations of Gst.XML methods (1.78 KB, patch)
2009-02-05 01:29 UTC, vasaka
needs-work Details | Review
message arg of gst_element_post_message takes ownership. (1.82 KB, patch)
2009-03-12 12:35 UTC, Zeeshan Ali
committed Details | Review
name arg of gst_ghost_pad_new is nullable. (1.68 KB, patch)
2009-03-12 13:00 UTC, Zeeshan Ali
committed Details | Review
caps arg of gst_element_get_compatible_pad is nullable. (1.75 KB, patch)
2009-03-12 13:27 UTC, Zeeshan Ali
committed Details | Review

Description Zeeshan Ali 2008-06-23 20:19:23 UTC
Some more minor gstreamer binding fixes.
Comment 1 Zeeshan Ali 2008-06-23 20:20:27 UTC
Created attachment 113291 [details] [review]
More gstreamer binding fixes
Comment 2 Jürg Billeter 2008-06-25 14:38:12 UTC
2008-06-25  Jürg Billeter  <j@bitron.ch>

	* vapi/packages/gstreamer-0.10/:

	More gst_tag_list_* binding fixes, patch by Zeeshan Ali Khattak,
	fixes bug 539817

	* vapi/gstreamer-0.10.vapi: regenerated

Fixed in r1646.
Comment 3 Zeeshan Ali 2008-12-17 15:20:10 UTC
Created attachment 124867 [details] [review]
Corrections for gst_element_make_from_uri().
Comment 4 Zeeshan Ali 2008-12-17 15:20:36 UTC
Created attachment 124868 [details] [review]
Regenerate the gstreamer-0.10 vapi.
Comment 5 Zeeshan Ali 2008-12-17 15:21:32 UTC
Re-openning the bug for the newly added patches.
Comment 6 Jürg Billeter 2008-12-17 21:27:30 UTC
2008-12-17  Jürg Billeter  <j@bitron.ch>

	* vapi/packages/gstreamer-0.10/:

	Fix gst_element_make_from_uri binding,
	patch by Zeeshan Ali Khattak, fixes bug 539817

	* vapi/gstreamer-0.10.vapi: regenerated

Fixed in r2203.
Comment 7 Zeeshan Ali 2008-12-28 00:57:56 UTC
Created attachment 125415 [details] [review]
gst_element_get_static_pad returns a ref
Comment 8 Zeeshan Ali 2008-12-28 01:03:57 UTC
Created attachment 125416 [details] [review]
Correct binding for gst_element_get_static_pad().
Comment 9 Zeeshan Ali 2008-12-29 00:12:36 UTC
Created attachment 125457 [details] [review]
Fixes to Gst.Registry bindings.

And some more minor fixes.
Comment 10 Jürg Billeter 2008-12-30 18:46:04 UTC
2008-12-30  Jürg Billeter  <j@bitron.ch>

	* vapi/packages/gstreamer-0.10/:

	Fix gst_element_get_static_pad and gst_regitry_* bindings,
	patch by Zeeshan Ali Khattak, fixes bug 539817

	* vapi/gstreamer-0.10.vapi: regenerated

Fixed in r2244.
Comment 11 Zeeshan Ali 2009-01-03 01:39:12 UTC
Created attachment 125672 [details] [review]
Minor fixes to gst_parse*() bindings.
Comment 12 Jürg Billeter 2009-01-03 17:36:05 UTC
2009-01-03  Jürg Billeter  <j@bitron.ch>

	* vapi/packages/gstreamer-0.10/:

	Fix gst_parse_* bindings, patch by Zeeshan Ali Khattak,
	fixes bug 539817

	* vapi/gstreamer-0.10.vapi: regenerated

Fixed in r2259.
Comment 13 vasaka 2009-02-04 11:57:25 UTC
in gstreamer.vapi

       public class XML : Gst.Object {
                           ...
               public XML ();
               [NoWrapper]
               ...
               public bool parse_file (uchar[] fname, uchar[] root);

should be

public bool parse_file (uchar[] fname, uchar[]? root);

because root can be NULL, as said in the documentation.
Comment 14 vasaka 2009-02-04 12:30:07 UTC
Created attachment 127922 [details] [review]
fixes parameter in public bool parse_file (uchar[] fname, uchar[] root);
Comment 15 vasaka 2009-02-05 01:29:03 UTC
Created attachment 127984 [details] [review]
fixes some method declarations of Gst.XML methods

there are several Gst.XML methods declared in gstreamer-0.10.vapi like

public bool parse_file (uchar[] fname, uchar[] root);

and because of such declaration one can not call it with literal string as parameter, like that:
parse_file ("filename", null);
valac comlains that it can not convert string to uchar if one passes uchar[] parameter to this function valac adds length of the string to the function call and this time gcc complains about additional parameters.

so declaration should be changed to 

public bool parse_file (string fname, string? root); //second parameter can be null as it said in documentation
Comment 16 vasaka 2009-02-05 01:29:19 UTC
Created attachment 127985 [details] [review]
fixes some method declarations of Gst.XML methods

there are several Gst.XML methods declared in gstreamer-0.10.vapi like

public bool parse_file (uchar[] fname, uchar[] root);

and because of such declaration one can not call it with literal string as parameter, like that:
parse_file ("filename", null);
valac comlains that it can not convert string to uchar if one passes uchar[] parameter to this function valac adds length of the string to the function call and this time gcc complains about additional parameters.

so declaration should be changed to 

public bool parse_file (string fname, string? root); //second parameter can be null as it said in documentation
Comment 17 Jürg Billeter 2009-02-20 15:09:23 UTC
Thanks for the patch. gstreamer-0.10.vapi is a generated file, though, as mentioned on the first line of the file. We'll need to update the .metadata file and regenerate the vapi.
Comment 18 Zeeshan Ali 2009-03-12 12:35:51 UTC
Created attachment 130508 [details] [review]
message arg of gst_element_post_message takes ownership.
Comment 19 Zeeshan Ali 2009-03-12 13:00:21 UTC
Created attachment 130512 [details] [review]
name arg of gst_ghost_pad_new is nullable.
Comment 20 Zeeshan Ali 2009-03-12 13:27:32 UTC
Created attachment 130513 [details] [review]
caps arg of gst_element_get_compatible_pad is nullable.
Comment 21 Zeeshan Ali 2009-03-15 21:17:55 UTC
I just `svn dcommit`ed my last weeks changes' to rygel, forgetting that it'll break the build without the last three patches I've provided. So please commit them soon'ish.
Comment 22 Jürg Billeter 2009-03-17 14:31:55 UTC
commit 02f853f2900d30f97a95c8df64e6319d5f5f284b
Author: Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Date:   Thu Mar 12 15:23:53 2009 +0200

    gstreamer-0.10: Fix gst_element_get_compatible_pad binding
    
    Caps parameter of gst_element_get_compatible_pad is nullable.

commit 95fb6a50d8b6828a62edcb7c323323e7fc21041c
Author: Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Date:   Thu Mar 12 14:56:54 2009 +0200

    gstreamer-0.10: Fix gst_ghost_pad_new binding
    
    Name parameter of gst_ghost_pad_new is nullable.

commit 408176dee0bc5e0074c5a200f40107098cf7dd32
Author: Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Date:   Thu Mar 12 14:32:24 2009 +0200

    gstreamer-0.10: Fix gst_element_post_message binding
    
    Message parameter of gst_element_post_message takes ownership.