GNOME Bugzilla – Bug 539790
[PATCH] Please add three new settings to GtkSettings
Last modified: 2008-07-14 23:51:14 UTC
Please merge the attached patched which adds three new props to GtkSettings and hooks them up to XSETTINGS. Basically they are intended to be used: 1) to specify the XDG sound theme to be used 2) to enable/disable event sounds globally 3) to disable only input feedback sounds (i.e. button clicks) but leave other event sounds (i.e. "you got mail!") enabled. I will shortly post a longer explanation of these settings to the xdg ml. Also see bug 539786.
Patch is here: http://0pointer.de/public/gtk-canberra.patch
Here's the mail to the XDG ML: http://lists.freedesktop.org/archives/xdg/2008-June/009711.html
These new settings will only ever be used by a sound module, correct ? Might be good to put a little comment to that effect in the docs. Where will that module live, btw ? It might be slightly more elegant to install the settings from the module, but I don't know if doing that from a module will cause complications - doing it from widget implementations is fairly common, e.g. see gtk-entry-select-on-focus.
(In reply to comment #3) > These new settings will only ever be used by a sound module, correct ? I am not sure about that. gtk-enable-input-feedback-sounds should probably be checked from widgets that want to have better control over the sounds generated and hence do the generation themselves instead of relying on libcanberra-gtk-module. Right now the gtk module is the only piece of code that generates feedback sounds, but I am sure it's eventually not going to stay that way. Hence: I think these properties are interesting for more than just the sound module. > Might be good to put a little comment to that effect in the docs. > Where will that module live, btw ? It lives in libcanberra right now. I see no reason to change that.
> Hence: I think these properties are interesting for more than just the sound > module. Ok > I see no reason to change that. Agreed. I was just curious. I've committed your patch: * gdk/x11/gdksettings.c: * gtk/gtksettings.c: Add event sound settings. Patch by Lennart Pöttering.
> Patch by Lennart Pöttering. Grr. s/Pöttering/Poettering/