After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 539624 - Crashes when copying text with xulrunner 1.9
Crashes when copying text with xulrunner 1.9
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
0.19.x
Other All
: Normal critical
: ---
Assigned To: Richard Hult
Richard Hult
Depends on:
Blocks:
 
 
Reported: 2008-06-22 17:41 UTC by Sam Morris
Modified: 2008-08-28 20:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sam Morris 2008-06-22 17:41:41 UTC 
Steps to reproduce:
1. Select text
2. Copy to clipboard

Stack trace:

+ Trace 201091

  • #0 ??
  • #1 do_command
    at dh-gecko-utils.cpp line 112
  • #2 dh_gecko_utils_copy_selection
    at dh-gecko-utils.cpp line 122
  • #3 dh_html_copy_selection
    at dh-html.c line 419
  • #4 window_activate_copy
    at dh-window.c line 639
  • #5 IA__g_closure_invoke
    at /tmp/buildd/glib2.0-2.16.3/gobject/gclosure.c line 490
  • #6 signal_emit_unlocked_R
    at /tmp/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2440
  • #7 IA__g_signal_emit_valist
    at /tmp/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2199
  • #8 IA__g_signal_emit
    at /tmp/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2243
  • #9 _gtk_action_emit_activate
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkaction.c line 877
  • #10 closure_accel_activate
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkaction.c line 1637
  • #11 IA__g_closure_invoke
    at /tmp/buildd/glib2.0-2.16.3/gobject/gclosure.c line 490
  • #12 signal_emit_unlocked_R
    at /tmp/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2440
  • #13 IA__g_signal_emit_valist
    at /tmp/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2209
  • #14 IA__g_signal_emit
    at /tmp/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2243
  • #15 IA__gtk_accel_group_activate
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkaccelgroup.c line 739
  • #16 IA__gtk_accel_groups_activate
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkaccelgroup.c line 777
  • #17 IA__gtk_window_activate_key
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkwindow.c line 8019
  • #18 gtk_window_key_press_event
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkwindow.c line 4962
  • #19 _gtk_marshal_BOOLEAN__BOXED
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkmarshalers.c line 84
  • #20 IA__g_closure_invoke
    at /tmp/buildd/glib2.0-2.16.3/gobject/gclosure.c line 490
  • #21 signal_emit_unlocked_R
    at /tmp/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2478
  • #22 IA__g_signal_emit_valist
    at /tmp/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2209
  • #23 IA__g_signal_emit
    at /tmp/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2243
  • #24 gtk_widget_event_internal
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkwidget.c line 4678
  • #25 IA__gtk_propagate_event
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkmain.c line 2310
  • #26 IA__gtk_main_do_event
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkmain.c line 1556
  • #27 gdk_event_dispatch
    at /build/buildd/gtk+2.0-2.12.10/gdk/x11/gdkevents-x11.c line 2351
  • #28 IA__g_main_context_dispatch
    at /tmp/buildd/glib2.0-2.16.3/glib/gmain.c line 2009
  • #29 g_main_context_iterate
    at /tmp/buildd/glib2.0-2.16.3/glib/gmain.c line 2642
  • #30 IA__g_main_loop_run
    at /tmp/buildd/glib2.0-2.16.3/glib/gmain.c line 2850
  • #31 IA__gtk_main
    at /build/buildd/gtk+2.0-2.12.10/gtk/gtkmain.c line 1163
  • #32 main
    at dh-main.c line 205 



Other information:
Forwarded from http://bugs.debian.org/485644. Analysis and a fix can be found there.

> Looks like the faulty code is in devhelp, after all ;)
> 
> gtk_moz_embed_get_nsIWebBrowser being NULL, it crashes, but the fact
> that gtk_moz_embed_get_nsIWebBrowser is NULL proves
> GTKEmbedGlueStartupInternal is not called, and obviously it is not
> called because GTKEmbedGlueStartupInternal is not defined (#ifdef)...
> which is totally normal, since it's a function, not a macro...
> 
> So, just remove #ifdef GTKEmbedGlueStartupInternal from
> dh-gecko-utils.cpp, and that should work.
Comment 1 Claudio Saavedra 2008-08-28 18:55:22 UTC 
I can confirm the suggested solution to fix the bug. May I commit the trivial fix?
Comment 2 Richard Hult 2008-08-28 19:30:15 UTC 
Yes, go ahead please, on the gnome-2-22 branch (which we will use for gnome 2.24)
Comment 3 Claudio Saavedra 2008-08-28 20:36:56 UTC 
Thanks. Fixed in gnome-2-22 (rev. 1046):

2008-08-28  Claudio Saavedra  <csaavedra@igalia.com>

	* src/dh-gecko-utils.cpp (dh_gecko_utils_init): Start up
	the embed glue. Fixes bug #539624.