GNOME Bugzilla – Bug 539570
Usefull general debug messages for MetaDataServiceJob.cs
Last modified: 2008-07-20 20:55:08 UTC
This patch adds a general start/stop marking debug message for every MetaData Provider.Makes it a lot easier to track origin of bugs if they are caused by such a Provider.
Created attachment 113191 [details] [review] General Start/End marker debug message for every MetaData Provider
Created attachment 113192 [details] [review] General Start/End marker debug message for every MetaData Provider - fixed spacing fixed spacing issue due to auto using tabs instead of 4 spaces.
Created attachment 113352 [details] [review] General Start/End marker debug message for every MetaData Provider rev3 Tweaked it some more, is now much more pleasant to look at / in use, console-output wise. See example for generated output.
Created attachment 113353 [details] MetadataServiceJob_LogDebug.console_output Example of console output from rev3 of this patch.
Created attachment 113357 [details] [review] General Start/End marker debug message for every MetaData Provider rev4 Ok, next time I will wait a week before entering a patch, printing it out and filling my walls with the code to stare on, since I always seem to mess it up...
Created attachment 113358 [details] MetadataServiceJob_LogDebug.console_output for rev4
Small nitpicking : I think the Log.Debug("") line should be removed. Having an empty line in the log just seems strange.
@betrand: It's the only way to keep it a bit clean in the log. Since while importing it will generate 7+ debuginfo lines for every album, which results in a enormous list that is very hard to read fast. With the empty line, it is much more readable, and therefore very easy to find out what went wrong where. Check out the "MetadataServiceJob_LogDebug.console_output for rev4" for what I mean: that's very readable.
This is a little too verbose - we want to keep the debug output actually usable.