GNOME Bugzilla – Bug 539142
Cannot go online manually if NM is not running
Last modified: 2009-08-27 13:58:41 UTC
Please describe the problem: When I loose the Internet connection, Empathy goes offline and when the Internet connection comes back, Empathy goes online. That's good. But when NM is not running, Empathy cannot know whether the Internet connection is available and I want to be able to go online manually. Steps to reproduce: 1. sudo /etc/init.d/network-manager stop 2. start Empathy 3. try to set your presence to "available" Actual results: 1. Empathy does not try to go online 2. No user feed back except if the user looks the debugs: DEBUG ("NM not connected"); Expected results: 1. Empathy try to go online. It may not work, but at least it should try. Does this happen every time? Yes Other information:
Fix in my branch "bug539142": http://git.collabora.co.uk/?p=user/alban/empathy;a=commitdiff;h=53d3474f82e4eaf7c55227c77c450bf76de31d23;hp=8ed913bcb03e99eb2f79da7d29d9f2994568e7b7
Well, I get "403 Forbidden - No such project" on this URL; could the patch be attached to the bug report, this avoids such availability problems and makes the bugzilla bug listing more useful.
Created attachment 113211 [details] [review] empathy-bug539142.patch Here is the patch. I fixed the URL too.
Thanks for the patch. 1) When Empathy starts do we want to try to connect accounts event if NM says we are offline? It will lead to connection error. 2) In idle_session_idle_changed_cb priv->nm_connected it doesn't restore presence if NM is not connected. In the case NM wrongly report it is not connected it should restore the presence. 3) We have the 'use_nm' gconf key for users that use a connection type not supported by NM, so they can disable the usage of NM. I think the real fix for this bug is to check if NM is running, if it is not priv->nm_connected should always be TRUE. What EmpathyIdle does is concidering NM always CONNECTED unless it says explicitely the state is CONNECTING or DISCONNECTED. In fact that's supposed to work, in empathy.c it calls empathy_idle_set_use_nm which gets the NM state. Please take a look at what it does, the call should fail and priv->nm_connected should be set to TRUE in that case.
> 1) When Empathy starts do we want to try to connect accounts event if NM says > we are offline? It will lead to connection error. It will only lead to a connection error if NM is right - which, FWIW, it isn't in my case where there's no working wireless and NM is 'not managing' the wired interface (in its own words) for whatever reason. Since it's not managing any interfaces it thinks connectivity is down, which isn't the case. I'd still very much like Empathy to connect on startup though without having to kill NM manually first.
Can we get this fixed, this is really a problem for people who isn't using NM (like me on my laptop).
(In reply to comment #6) > Can we get this fixed, this is really a problem for people who isn't using NM > (like me on my laptop). Does unset the /apps/empathy/use_nm gconf key help?
Hmm. I don't even have network manager installed and I have no problem at all with Empathy going online on both gnome and xfce. I've tested in both desktop to test the "/apps/empathy/use_nm" gconf key and it had no impact.
Could you retry with Empathy 2.27.91.1? Connectivity support has been improved.
If you have NM running, and you set the new /apps/empathy/use_conn gconf key to FALSE, then you will be able to connect, regardless of what connectivity NM reports. I'm tempted to mark this as RESOLVED FIXED, because I'm pretty confident it works.
Closing the bug then. Feel free to re-open if you experience issue with the latest release.