After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 538946 - Problem with the Repeat option
Problem with the Repeat option
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Last.fm
1.0.0
Other Linux
: Normal normal
: 1.2
Assigned To: Gabriel Burt
Depends on:
Blocks:
 
 
Reported: 2008-06-18 12:14 UTC by Zoltan Kuscsik
Modified: 2008-06-25 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only restore shuffle and repeat mode when we switch to a non Last.fm source (1.31 KB, patch)
2008-06-18 19:28 UTC, Bertrand Lorentz 		committed Details | Review

Description Zoltan Kuscsik 2008-06-18 12:14:11 UTC 
Setting the "Repeat single" option on a local playlist and switching to 
a Last.fm playlist repeats also the Last.fm tracks. Nevertheless, the "Playback>Repeat" menu option is disabled for Last.fm playlists, so I need to switch back to a local playlist to disable the Repeat function for the Last.fm tracks.
Comment 1 Bertrand Lorentz 2008-06-18 19:21:16 UTC 
The scenario to reproduce this is actually as follows :

1. Set the "Repeat single" option
2. Play from a local playlist
3. Play from a Last.fm station : repeat is set to Off, it's OK
4. Play from another Last.fm station : repeat goes back to "Repeat single"

I'll post a patch that fixes this shortly.
Comment 2 Bertrand Lorentz 2008-06-18 19:28:20 UTC 
Created attachment 113007 [details] [review]
Only restore shuffle and repeat mode when we switch to a non Last.fm source

Anyone having question about this patch should first brush up on his Boolean algebra. ;)
Comment 3 Gabriel Burt 2008-06-24 22:28:06 UTC 
Haha, thanks Bertrand.  Actually, if you just read it aloud, it's easy. :)  Please commit.
Comment 4 Bertrand Lorentz 2008-06-25 17:50:00 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.