After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 538663 - gdppay memleak in gst_gdp_pay_reset
gdppay memleak in gst_gdp_pay_reset
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal minor
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-16 20:02 UTC by Antoine Tremblay
Modified: 2008-06-20 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix the leak (530 bytes, patch)
2008-06-16 20:02 UTC, Antoine Tremblay
committed Details | Review

Description Antoine Tremblay 2008-06-16 20:02:16 UTC
in _reset the buffers in queue are deleted from the queue without being unreffed,

also there's a debug message that says they they are pushed but it's no the case
and it shouldn't be the case..

So here's a patch to fix the memleak and remove the bogus message
Comment 1 Antoine Tremblay 2008-06-16 20:02:49 UTC
Created attachment 112865 [details] [review]
patch to fix the leak
Comment 2 Sebastian Dröge (slomo) 2008-06-17 08:28:13 UTC
Looks good, I'll commit it after freeze.
Comment 3 Sebastian Dröge (slomo) 2008-06-20 08:45:09 UTC
2008-06-20  Sebastian Dröge  <slomo@circular-chaos.org>

        Patch by: Antoine Tremblay <hexa00 at gmail dot com>
        
        * gst/gdp/gstgdppay.c: (gst_gdp_pay_reset):
        Fix a buffer memleak and remove a confusing and wrong debug output.
        Fixes bug #538663.