Created attachment 112841 [details] [review]
hello world patch (obsolete)

thanks for the patch. some comments:

* was the hello-workd.fig meant to be part of the patch?
* parser   = gst_element_factory_make ("oggdemux",      "ogg-parser");
  name the element maybe "ogg-demux" too?
* I think its fine to leave the comments lower case (its still not consistent anyway)

(In reply to comment #2)
> thanks for the patch. some comments:
> 
> * was the hello-workd.fig meant to be part of the patch?

yes, the diagram is missing 2 elements. 
(I redrew the diagram in svg, but I still need to integrate this with the build system, so I did a quick .fig update)

> * parser   = gst_element_factory_make ("oggdemux",      "ogg-parser");
>   name the element maybe "ogg-demux" too?
ok

> * I think its fine to leave the comments lower case (its still not consistent
> anyway)
(I don't get it)

Created attachment 112904 [details] [review]
hello world patch update

Comment on attachment 112841 [details] [review]
hello world patch (obsolete)

(what is the way to mark attachments obsolete? I thought there was an option here...)

Thanks!

2008-06-25  Stefan Kost  <ensonic@users.sf.net>

	patch by: Luc Pionchon  <luc.pionchon@nokia.com>

	* docs/manual/basics-helloworld.xml:
	* docs/manual/hello-world.fig:
	  - Explicitely include glib.h.
	  - Do not use global variables.
	  - Use g_printerr() instead of g_print().
	  - Minor formating/renaming to increase readibility.
	  - Renamed new_pad() to on_pad_added()
	  - Improved explenatory comments.
	  - renamed ogg parser to ogg demuxer
	  - Use "autoaudiosink" instead of "alsasink".
	  Fixes: #538619