After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 538560 - [mpegtsparse] static caps reference counter incremented indefinitely
[mpegtsparse] static caps reference counter incremented indefinitely
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal minor
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-16 08:49 UTC by Vincent Génieux
Modified: 2008-06-16 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix for the bug (1.09 KB, patch)
2008-06-16 08:53 UTC, Vincent Génieux 		committed Details | Review

Description Vincent Génieux 2008-06-16 08:49:49 UTC 
Each calls to the function mpegts_parse_push increments the src_template.static_caps.refcount by one.

Running mpegtsparse on a live mpegts source for a very long time (two or three days) drives to an error message : 
"Gstreamer-Critical: file gstcaps.c (gst_caps_unref): GST_CAPS_REFCOUNT_VALUE (caps) > 0"

The attached patch fix this issue.
Comment 1 Vincent Génieux 2008-06-16 08:53:06 UTC 
Created attachment 112815 [details] [review]
fix for the bug

unref the caps after gst_buffer_set_caps function call.
Comment 2 Zaheer Abbas Merali 2008-06-16 14:24:12 UTC 
thanks for the patch and report. for future reference please use unified diffs as they are easier to read. thanks.