After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 538468 - Incorrect display of file permissions: group S-Bit is used for user S-Bit
Incorrect display of file permissions: group S-Bit is used for user S-Bit
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: List View
0.x.x [obsolete]
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-15 17:05 UTC by Marcel Stimberg
Modified: 2008-06-16 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch correcting S_ISGID --> S_ISUID (501 bytes, patch)
2008-06-15 17:22 UTC, Marcel Stimberg
committed Details | Review

Description Marcel Stimberg 2008-06-15 17:05:00 UTC
Bug reported by Matty Dee in the Ubuntu bug tracker for 2.22 ( https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/240165 ) but still present in trunk:

touch zzz
chmod g+s zzz

ls -l zzz

gives:
-rw-r-Sr-- 1 matty media 0 2008-06-15 06:31 zzz

nautilus reports:
-rwSr-Sr--
Comment 1 Marcel Stimberg 2008-06-15 17:22:41 UTC
Created attachment 112787 [details] [review]
Patch correcting S_ISGID --> S_ISUID

Both suid and sgid test for S_ISGID, suid should test for S_ISUID instead.
Comment 2 A. Walton 2008-06-15 17:33:36 UTC
Looks obviously correct to me, probably a copy+paste error. Should go in 2.22 and trunk. Thanks!
Comment 3 A. Walton 2008-06-16 16:24:15 UTC
I went ahead and committed this on your behalf; I wasn't sure if you had svn access or not. 

2008-06-16  A. Walton  <awalton@gnome.org>

	* libnautilus-private/nautilus-file.c
	(nautilus_file_get_permissions_as_string):
	Correct a typo in the permissions code: 
	suid should test for S_ISUID instead of G_ISGID.
	Closes bug #538468.
	Patch by Marcel Stimberg.

Closing as FIXED. Thanks again!