GNOME Bugzilla – Bug 538339
Should use a nicer invisible-char
Last modified: 2009-04-24 08:57:40 UTC
Please describe the problem: The 'dot' seems more common than the star '*' nowadays for usage in password dialogs. Patch attached. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 112738 [details] [review] Use more gnomish invisible char
Comment on attachment 112738 [details] [review] Use more gnomish invisible char >+ gtk_widget_set(entry, "invisible-char", 0x25cf, NULL); No. Nothing should explicitly set this ever anywhere in GNOME, really. This should be a GTK+ setting that is done by the system GTK or the user in their .gtkrc, really. Fedora uses 0x2022, I think Debian uses 0x25cf, and some distros still prefer '*'. My guess is that there's something in the glade file that sets this, and that line(s) should be removed so it falls back to the OS default.
The point here is, that GtkSecureEntry sets this to '*'. I can set a nicer default there then so distros can still override this via their theme.
Created attachment 133202 [details] [review] better patch Here is a patch that uses the same character that GTK+ would choose. Applying it shows that the sec entry cannot actually coexist with entries in the same process without warnings, but the warnings are harmless.
I basically used the same trick to get rid of the warning: don't install the "gtk-entry-select-on-focus" but query it from GtkEntry when needed. Patch applied, thanks.