GNOME Bugzilla – Bug 538019
Preferences window opens automatically
Last modified: 2008-09-21 14:10:10 UTC
Please describe the problem: The preferences window opens when you start tasque. It should open the first time when you're setting the backend, but not afterward. This might be because when tasque opens on system startup, there might not be internet yet, so it tries the backend and fails. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Okay, I had lost the connection to RTM somehow. After authenticating it didn't bring up the preferences window. Need to restart and see if it clears the authentication when it can't find internet.
Yeah, if you add tasque to startup, then restart and it's slow to acquire internet (e.g., wireless), then it will lose its authentication with RTM.
Here are the pieces of the problem: 1) If there is an exception while authenticating with RTM, it throws away the credentials. 2) Application only attempts to initialize the backend once, then gives up, so lack of Internet will cause 1). Submitting patch for 1).
Created attachment 112644 [details] [review] Handles different kinds of exceptions during authentication differently
Created attachment 112648 [details] [review] Addresses 1) and 2) above
Created attachment 112649 [details] [review] Addresses 1) and 2) above
Okay, this patch does 1) and 2). It makes the decision that the preferences window won't open automatically in the case where there's a valid backend but it's not authenticating yet.
Created attachment 117171 [details] [review] Patch updated for SVN Updated patch for SVN; on first run (with my RTM association already lost) it hides the Tasque window; I'll test it further.
Having tested this for a week, this patch has worked well for me. I can see it happen: Tasque starts before it can connect to my tasks, fails, but tries again in a few seconds and succeeds. (Also, bumping severity; this is definitely not trivial. :)
Andrew, do you have GNOME SVN access? Feel free to commit.
(In reply to comment #10) > Andrew, do you have GNOME SVN access? Feel free to commit. I do not, but if you think I should, feel free to email me.
Committed in r104. Thanks Joseph and Andrew, and sorry for the delay in getting this in.