After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 537682 - View Artist on Wikipedia uses + instead of _ as word delimiter
View Artist on Wikipedia uses + instead of _ as word delimiter
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
1.0.0
Other Linux
: Normal normal
: 1.2
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-10 21:13 UTC by Ryan Shea
Modified: 2008-07-28 01:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix wikipedia last.fm linking (1.18 KB, patch)
2008-06-20 20:54 UTC, Ryan Shea 		rejected Details | Review

Description Ryan Shea 2008-06-10 21:13:42 UTC 
If you highlight last.fm in the sidebar, then right-click on a recently loved track and choose "View Artist on Wikipedia" - if the artist is a multi-word artist such as Billy Joel the wikipedia article will not come up.  It looks like the + sign is being used as a word delimiter and this should be an _.
Comment 1 Ryan Shea 2008-06-20 20:54:37 UTC 
Created attachment 113147 [details] [review]
patch to fix wikipedia last.fm linking

this is my first ever patch, so any pointers on why this is terrible would be great... but it does seem to work.
Comment 2 Alex Launi 2008-06-25 14:05:31 UTC 
Why do you call WikiEncode? That method seems to do absolutely nothing. Also this does not work for Artists with special characters in their name, ex) Hall & Oates.
Comment 3 Gabriel Burt 2008-06-25 15:04:29 UTC 
Yeah, the spaces get turned into plus signs by the Encode method.  All the patch should be is a artist.Replace (' ', '_') call before sending it into the Encode (with a null check).
Comment 4 Ryan Shea 2008-06-25 21:20:15 UTC 
Ok.  I'll see if I can do that.  I am quite inexperienced in C#, so I just did what I could to get it to work.  Thanks for the feedback.
Comment 5 Gabriel Burt 2008-07-28 01:27:21 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.