After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 537543 - [pulse] sink/src should have "volume" property (was GstMixer)
[pulse] sink/src should have "volume" property (was GstMixer)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-10 09:01 UTC by Marc-Andre Lureau
Modified: 2009-01-29 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Marc-Andre Lureau 2008-06-10 09:01:53 UTC 
Playbin2 is using the mixer interface of the sink if available.

In order to get rid of the duplication of volume control, we should have in in pulse sink/src.

see bug 473841
Comment 1 Marc-Andre Lureau 2008-06-10 09:03:07 UTC 
btw, I just started this work on the sink and have some issue with multi-threading stuff ;).
Comment 2 Tim-Philipp Müller 2008-06-10 09:19:07 UTC 
> Playbin2 is using the mixer interface of the sink if available.

playbin2 will look for a "volume" property on the sink, you don't have to implement the mixer interface just for the stream-volume thing.
Comment 3 Marc-Andre Lureau 2008-06-10 09:23:23 UTC 
(In reply to comment #2)

> playbin2 will look for a "volume" property on the sink, you don't have to
> implement the mixer interface just for the stream-volume thing.


thanks for the info :)
Comment 4 Sebastian Dröge (slomo) 2008-08-13 13:57:33 UTC 
With this commit pulsesink has commented out (because not working) support for a "volume" property. If someone could find the reason why it doesn't work that'd be great :)

2008-08-13  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

	* ext/pulse/pulsesink.c: (gst_pulsesink_class_init),
	(gst_pulsesink_init), (gst_pulsesink_finalize),
	(gst_pulsesink_set_volume), (gst_pulsesink_get_volume),
	(gst_pulsesink_set_property), (gst_pulsesink_get_property),
	(gst_pulsesink_prepare), (gst_pulsesink_change_state):
	* ext/pulse/pulsesink.h:
	Add "device-name" property to pulsesink too and currently commented
	out and not working support for a "volume" property.
Comment 5 Sebastian Dröge (slomo) 2009-01-29 13:33:24 UTC 
This is fixed in GIT and 0.10.14 will contain the fix.