After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 537380 - [gnomevfssrc] Doesn't handle short reads properly
[gnomevfssrc] Doesn't handle short reads properly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.21
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-09 10:55 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2008-07-29 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
loop over short reads (2.08 KB, patch)
2008-06-09 10:55 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2008-06-09 10:55:12 UTC 
Bug #536848 also applies to gnomevfssrc.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2008-06-09 10:55:55 UTC 
Created attachment 112409 [details] [review]
loop over short reads
Comment 2 Jan Schmidt 2008-06-11 08:54:41 UTC 
This looks fine, but it's not a regression - is it worth breaking freeze for? Opinions, please.
Comment 3 Sebastian Dröge (slomo) 2008-06-11 09:38:53 UTC 
Well, it will fail the same way as for GIO when reading from a smb URI but OTOH nobody every reported this before so maybe random access is not used for smb in gnomevfssrc or something.

I'd be fine with waiting after release
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2008-06-11 14:36:44 UTC 
No regression, lets do after release. It basically restores the semantics of the pull_range, so that elements get what they asked for.

Btw. its also needed when you have queue with levels in buffer counts to get what you ask for. We had huge buffer counts to 'ensure' that we get enough data in preroll because of this.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2008-07-29 12:36:46 UTC 
2008-07-29  Stefan Kost  <ensonic@users.sf.net>

	* ext/gnomevfs/gstgnomevfssrc.c:
	  Aggregate short reads and add some comments and debug logging.
	  Fixes #537380