After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 537004 - Notifications broken
Notifications broken
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal normal
: 1.2
Assigned To: Banshee Maintainers
Banshee Maintainers
: 537119 542862 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-06-06 16:31 UTC by Sandy Armstrong
Modified: 2008-07-14 10:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Quick fix patch, works for me. (832 bytes, patch)
2008-06-06 16:45 UTC, Sandy Armstrong 		none Details | Review
Fix notifications and cleanup (1.13 KB, patch)
2008-06-12 16:43 UTC, Bertrand Lorentz 		committed Details | Review

Description Sandy Armstrong 2008-06-06 16:31:05 UTC 
For several revisions now, track change notifications have not appeared.  I poked around a bit in NotificationAreaService.cs and found that ServiceManager.PlayerEngine.CurrentTrack is null when it's time to create and show the notification, so no notification is created.
Comment 1 Sandy Armstrong 2008-06-06 16:37:37 UTC 
Actually that's not entirely correct...ServiceManager.PlayerEngine.CurrentTrack isn't being checked on the StartOfStream notification...will keep digging.
Comment 2 Sandy Armstrong 2008-06-06 16:45:28 UTC 
Created attachment 112284 [details] [review]
Quick fix patch, works for me.
Comment 3 Bertrand Lorentz 2008-06-06 17:47:32 UTC 
Reverting this commit also fixes the problem :
http://svn.gnome.org/viewvc/banshee/trunk/banshee/src/Extensions/Banshee.NotificationArea/Banshee.NotificationArea/NotificationAreaService.cs?r1=4093&r2=4102

After this commit, OnPlayerEvent is never called for Iterate, so current_track never gets updated.

As I don't know what the Iterate event really is, I won't dare to propose a patch... ;)
Comment 4 Bertrand Lorentz 2008-06-07 20:43:00 UTC 
*** Bug 537119 has been marked as a duplicate of this bug. ***
Comment 5 Bertrand Lorentz 2008-06-12 16:43:24 UTC 
Created attachment 112628 [details] [review]
Fix notifications and cleanup

This patch builds up on sandy's and goes a small step further by cleaning up unused code.
Comment 6 Gabriel Burt 2008-06-24 22:16:06 UTC 
Committed, thanks guys!
Comment 7 Bertrand Lorentz 2008-07-14 10:01:27 UTC 
*** Bug 542862 has been marked as a duplicate of this bug. ***