After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536994 - Improve v4l2src negotiation a bit more
Improve v4l2src negotiation a bit more
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.9
Assigned To: Sebastian Dröge (slomo)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-06 15:35 UTC by Sjoerd Simons
Modified: 2008-06-09 08:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
If an exact match isn't available, try to the closest resolution (2.32 KB, patch)
2008-06-06 15:50 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2008-06-06 15:35:31 UTC 
The last change to the v4l2src makes it try to pick an optimal resolution. This currently only works nicely when the camera can actually deliver that resolution.. Say my camera can do up to 1600x1200 and the various resolutions it can provide includes 320x240, but not 300x200. In a pipeline with as target resolution 320x240 the camera will actually capture at that size, but if you request 300x200 then it'll capture at 1600x1200 and waste a lot of cpu on downscaling

Instead if the intersection of the caps result in multiple (resolution) option it should pick the smallest one greater then the resolution specified in the first caps entry of the peer
Comment 1 Sjoerd Simons 2008-06-06 15:50:20 UTC 
Created attachment 112283 [details] [review]
If an exact match isn't available, try to the closest resolution
Comment 2 Sebastian Dröge (slomo) 2008-06-09 08:51:52 UTC 
2008-06-09  Sebastian Dröge  <slomo@circular-chaos.org>

        Patch by: Sjoerd Simons <sjoerd at luon dot net>

        * sys/v4l2/gstv4l2src.c: (gst_v4l2src_negotiate):
        Improve negotiation a bit more by picking the smallest possible
        resolution that is larger than the resolution specified in the
        first caps entry of the peer caps. Fixes bug #536994.