After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536981 - gstdoc-scangobj: printf-like functions without format string
gstdoc-scangobj: printf-like functions without format string
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
git master
Other Linux
: Normal normal
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-06 13:52 UTC by Sebastian Dröge (slomo)
Modified: 2008-06-20 08:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstdoc-scangobj.diff (1.17 KB, patch)
2008-06-06 13:52 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2008-06-06 13:52:07 UTC 
Hi,
gstdoc-scangobj currently uses some printf-like functions without format string. This leads to compiler warnings with -Wformat=2:

cc1: warnings being treated as errors
gstreamer-scan.c: In function 'output_hierarchy':
gstreamer-scan.c:712: error: format not a string literal and no format
arguments
gstreamer-scan.c: In function 'output_interfaces':
gstreamer-scan.c:763: error: format not a string literal and no format
arguments
gstreamer-scan.c: In function 'output_prerequisites':
gstreamer-scan.c:808: error: format not a string literal and no format
arguments

Attached patch fixes this, will commit after freezes.
Comment 1 Sebastian Dröge (slomo) 2008-06-06 13:52:44 UTC 
Created attachment 112277 [details] [review]
gstdoc-scangobj.diff
Comment 2 Sebastian Dröge (slomo) 2008-06-20 08:43:21 UTC 
2008-06-20  Sebastian Dröge  <slomo@circular-chaos.org>

        * gstdoc-scangobj:
        Always use format strings for printf-like functions, even if they just
        print a string. Fixes bug #536981.