After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536978 - GTKDOC_CFLAGS should include CFLAGS
GTKDOC_CFLAGS should include CFLAGS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 546870 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-06-06 13:38 UTC by Sebastian Dröge (slomo)
Modified: 2008-08-19 01:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2008-06-06 13:38:54 UTC 
Hi,
docs/gst/Makefile.am currently sets GTKDOC_CFLAGS = $(GST_OBJ_CFLAGS). This is fine but it should also contain CFLAGS, otherwise stuff given to configure via the CFLAGS environment variable, etc does not have any effect.

I'll change this in core/base after the freezes and everywhere else on Monday.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2008-06-07 16:37:56 UTC 
Not sure if that shouldn't be better fixed in gtk-doc.make

scan-build.stamp: 
...
	    CC="$(GTKDOC_CC)" LD="$(GTKDOC_LD)" CFLAGS="$(GTKDOC_CFLAGS)" LDFLAGS="$(GTKDOC_LIBS)" gtkdoc-scangobj $(SCANGOBJ_OPTIONS) --module=$(DOC_MODULE) --output-dir=$(srcdir) ;
...
Comment 2 Sebastian Dröge (slomo) 2008-06-08 10:43:47 UTC 
That would the other possibility, yes :)
Comment 3 Sebastian Dröge (slomo) 2008-06-09 08:05:12 UTC 
Ok, well let's add it in gtk-doc.make then. Will you add this in the gtk-doc gtk-doc.make in SVN? :)
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2008-06-10 18:55:30 UTC 
Done:
2008-06-10  Stefan Kost  <ensonic@users.sf.net>

	* gtk-doc.make:
	* gtk-doc.notmpl.make:
	* tests/gtk-doc.make:
	* tests/gtk-doc.notmpl.make:
	  Include original CFLAGS / LDFLAGS when building the scanner. Allows to
	  have own FLAGS defined in addition.
Comment 5 Sebastian Dröge (slomo) 2008-06-20 08:42:03 UTC 
2008-06-20  Sebastian Dröge  <slomo@circular-chaos.org>

        * gtk-doc-plugins.mak:
        * gtk-doc.mak:
        Include CFLAGS and LDFLAGS in GTKDOC_CFLAGS and GTKDOC_LDFLAGS,
        otherwise the values passed to configure are ignored.
        Fixes bug #536978.
Comment 6 David Schleef 2008-08-18 02:55:03 UTC 
*** Bug 546870 has been marked as a duplicate of this bug. ***
Comment 7 rob1weld 2008-08-19 01:02:01 UTC 
It is broken in: http://gstreamer.freedesktop.org/src/gstreamer/gstreamer-0.10.20.tar.bz2 on target i386-pc-solaris2.11. Looking forward to 0.10.21 .