After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536968 - Potentially huge leak because of the usage of the status bar
Potentially huge leak because of the usage of the status bar
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.22.x
Other Linux
: Urgent major
: 2.22.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-06 11:25 UTC by Vincent Untz
Modified: 2008-06-29 11:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Plug status bar leak (1.03 KB, patch)
2008-06-06 11:25 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2008-06-06 11:25:05 UTC 
Reported at https://bugzilla.novell.com/show_bug.cgi?id=397852

Michael Meeks had a nice case where he had 915813 messages in the status bar stack. That's, err, quite a lot of messages :-)

That's happening because we push messages but nearly always forget to pop them. This is most visible on the desktop because it's the nautilus window that is always present.

(it's also kind of weird to have a status bar for the desktop -- but maybe it's used in some way for a11y tools?)

Attaching a patch to fix this.
Comment 1 Vincent Untz 2008-06-06 11:25:34 UTC 
Created attachment 112269 [details] [review]
Plug status bar leak
Comment 2 Cosimo Cecchi 2008-06-08 12:58:55 UTC 
Setting patch status as for Christian's comment on the nautilus m-l.
Comment 3 Cosimo Cecchi 2008-06-29 11:06:33 UTC 
I committed this now to trunk and gnome-2-22 so that it will be in the tarball for GNOME 2.22.3. Closing as FIXED.

2008-06-29  Cosimo Cecchi  <cosimoc@gnome.org>

	* src/nautilus-window.c: (nautilus_window_set_status):
	Fix a huge leak as messages were pushed in the statusbar but almost
	never popped. Patch by Vincent Untz. (#536968).