After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536582 - Highlight option of Rect & Elipse Select does not save on exit.
Highlight option of Rect & Elipse Select does not save on exit.
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.4.x
Other All
: Normal minor
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2008-06-04 11:39 UTC by vabijou
Modified: 2008-10-30 20:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (5.26 KB, patch)
2008-06-04 13:47 UTC, Sven Neumann 		committed Details | Review

Description vabijou 2008-06-04 11:39:13 UTC 
The Highlight checkbox on the Rectangle Select tool and the Elipse Select tool does not save on exit, when the Preferences>Tool Options>Save Tool Options on Exit is activated or you try to force a save with Preferences>Tool Options>Save Tool Options Now.
Comment 1 Sven Neumann 2008-06-04 13:47:37 UTC 
Created attachment 112131 [details] [review]
proposed patch

Indeed, the code that is supposed to change the default value of "highlight" for the rectangle select tools breaks the serialisation of this property. Attached is a patch for review.
Comment 2 Sven Neumann 2008-06-04 13:58:25 UTC 
Applied to both branches:

2008-06-04  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcropoptions.c
	* app/tools/gimprectangleoptions.c
	* app/tools/gimprectangleselectoptions.c: fixed handling of the
	"highlight" property that needs different default values for the
	Crop and Rectangle Select tools (bug #536582).
Comment 3 vabijou 2008-06-05 02:40:22 UTC 
Thanks for your attention to this.  Does this fix cover the Elipse Select tool as well?