GNOME Bugzilla – Bug 536334
Dia help fails while compiled without GNOME
Last modified: 2008-08-10 04:41:13 UTC
Please describe the problem: Nothing happens when you press help/help (without GNOME support) Steps to reproduce: 1. ./autogen.sh && make && sudo make install 2. /usr/local/bin/dia 3. select help/help Actual results: Just nothing! Expected results: Opening some window with help in. Does this happen every time? Yep! Other information: stack trace: read(3, "\1\2\233\27\0\0\0\0`\0\300\1\4\0\0\0(\0\0\0\4\0\0\0p(\34"..., 32) = 32 open("/usr/local/share/dia/help", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY) = 6 fstat64(6, {st_mode=S_IFDIR|S_ISGID|0755, st_size=4096, ...}) = 0 fcntl64(6, F_SETFD, FD_CLOEXEC) = 0 getdents64(6, /* 7 entries */, 4096) = 168 getdents64(6, /* 0 entries */, 4096) = 0 close(6) = 0 rt_sigaction(SIGINT, {SIG_IGN}, {0xb7079120, [], 0}, 8) = 0 rt_sigaction(SIGQUIT, {SIG_IGN}, {SIG_DFL}, 8) = 0 rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 clone(child_stack=0, flags=CLONE_PARENT_SETTID|SIGCHLD, parent_tidptr=0xbfda5d44 ) = 5272 waitpid(5272, [{WIFEXITED(s) && WEXITSTATUS(s) == 0}], 0) = 5272 rt_sigaction(SIGINT, {0xb7079120, [], 0}, NULL, 8) = 0 rt_sigaction(SIGQUIT, {SIG_DFL}, NULL, 8) = 0 rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 --- SIGCHLD (Child exited) @ 0 (0) --- gettimeofday({1211926549, 660413}, NULL) = 0
with the current version the html files are installed to $PREFIX/share/doc/dia/$LANG/html which does not match the assumption in code (app/commands.c:help_manual_callback) checks for $PREFIX/share/dia/help/$LANG with falback to LANG=C given how gimp's help file are installed I think the installation needs adaption: there is /usr/share/gimp/2.0/help/en/index.html
Created attachment 113618 [details] [review] svn diff -x '-u' => candidate *BACKPORTED* patch, *see comment* /usr/share/gimp/2.0/help/en/index.html ^^^^^^^^^^ Obviously! If we don't have gnome support, we assumes that yelp is not here, so use an html browser instead... I corrected that in my working copy, but I'm currently unable to backport a patch without conflicts from BUG #465460. Here is a candidate backported patch, but *BE AWARE THAT YOU WILL EXPERIENCE PROBLEMS WITH IT, INCLUDING CONFLICTS WITH PACHES FROM BUG #45460* As soon as you'll apply corrections * BUG #465460 COMMENT#18 * BUG #465460 COMMENT#19 I will post an (I hope) definitive patch
Thanks, adapted and applied: 2008-06-29 Hans Breuer <hans@breuer.org> [Patch from Thomas Harding fixing help generation for non-gnome case] * xmldocs.make : without gnome install to $(helpdocdir) * configure.in : initialize HAVE_XSLTPROC * hardcopies.make : conditionalize on HAVE_GNOME
Unfortunately, the candidate patch was not complete and not really finalized. * documentation uninstall is not complete * symlinks should be done on $(helpdocdir) instead of $(DESTDIR)$(helpdocdir) to make packagers life easier (this results in dangling symlinks while $(DESTDIR) != "", then symlinks are correct while the package is installed from $(DESTDIR) to "/")
Created attachment 113633 [details] [review] svn diff -x '-u' => symlinks and uninstall patch SEE BUG #536334 COMMENT#4
hope this settles the issue ;) 2008-07-06 Hans Breuer <hans@breuer.org> [Patch from Thomas Harding fixing help finally fixing bug #536334] * doc/Makefile.am hardcopies.make : - documentation uninstall was not complete - symlinks are done on $(helpdocdir) instead of $(DESTDIR)$(helpdocdir) to make packagers life easier (this results in dangling symlinks while $(DESTDIR) != "", then symlinks are correct while the package is installed from $(DESTDIR) to "/")
*** Bug 493693 has been marked as a duplicate of this bug. ***
*** Bug 147728 has been marked as a duplicate of this bug. ***