After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536313 - [cdda] Remove sha1 copy once we depend on glib-2.16
[cdda] Remove sha1 copy once we depend on glib-2.16
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.24
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-02 20:13 UTC by Bastien Nocera
Modified: 2009-05-26 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove copy of sha1 digest (15.35 KB, patch)
2008-06-02 20:22 UTC, Bastien Nocera
none Details | Review
Updated patch (15.46 KB, patch)
2008-08-21 14:19 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2008-06-02 20:13:03 UTC
Should be using g_checksum_* from glib 2.16 instead.
Comment 1 Bastien Nocera 2008-06-02 20:22:09 UTC
Created attachment 111994 [details] [review]
Remove copy of sha1 digest

Something like that, completely untested.
Comment 2 Tim-Philipp Müller 2008-06-02 22:42:48 UTC
Sadly we won't be able to depend on GLib >= 2.16 in the near future. (Not even sure if we really need to leave this bug open, since it's on our radar anyway ...)

Comment 3 Bastien Nocera 2008-08-21 14:19:15 UTC
Created attachment 117141 [details] [review]
Updated patch

And a patch that actually compiles.
Comment 4 Wim Taymans 2009-05-26 09:49:30 UTC
commit 9c508ba4582d8a7b452a47d9a466830fa50ce87e
Author: Bastien Nocera <hadess at hadess.net>
Date:   Tue May 26 11:11:03 2009 +0200

    cddabasesrc: Remove copy of sha1 digest
    
    Remove our copy of sha1 digest now that we depend on glib 2.16.
    Fixes #536313