After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536274 - handle flush seeking in amrnbparse
handle flush seeking in amrnbparse
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: 0.10.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-02 15:48 UTC by Benoit Fouet
Modified: 2008-09-26 10:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to handle flush seek (7.08 KB, patch)
2008-06-02 15:49 UTC, Benoit Fouet
committed Details | Review

Description Benoit Fouet 2008-06-02 15:48:32 UTC
please find attached a patch to do so...
(it is quite not complete, but have no time at the moment, if someone wants to finish it, please do)
Comment 1 Benoit Fouet 2008-06-02 15:49:17 UTC
Created attachment 111962 [details] [review]
patch to handle flush seek
Comment 2 Wim Taymans 2008-06-02 16:57:50 UTC
This only works when all the blocks all have an equal size.
Comment 3 Benoit Fouet 2008-06-03 06:50:51 UTC
(In reply to comment #2)
> This only works when all the blocks all have an equal size.
> 

AFAIK, there is no variable bitrate in AMR-NB, is there ?
Comment 4 Benoit Fouet 2008-06-20 14:44:47 UTC
note, the patch also lacks the emission of the flush event on the sink side...
Comment 5 Wim Taymans 2008-09-26 10:05:10 UTC
        Patch by: Benoit Fouet <benoit dot fouet at purplelabs dot com>

        * ext/amrnb/amrnbparse.c: (gst_amrnbparse_init),
        (gst_amrnbparse_handle_pull_seek),
        (gst_amrnbparse_handle_push_seek), (gst_amrnbparse_src_event),
        (gst_amrnbparse_sink_activate_push),
        (gst_amrnbparse_sink_activate_pull):
        * ext/amrnb/amrnbparse.h:
        Add flush seek handler. Fixes #536274.