After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536226 - fix query duration
fix query duration
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: 0.10.10
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-02 12:39 UTC by Benoit Fouet
Modified: 2008-09-26 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for query (3.77 KB, patch)
2008-06-02 12:40 UTC, Benoit Fouet 		none Details | Review
combined patch (3.87 KB, patch)
2008-06-05 11:11 UTC, Benoit Fouet 		committed Details | Review

Description Benoit Fouet 2008-06-02 12:39:20 UTC 
this patch fixes the query duration in amr parser element.

Note: we do not care about the 6 bytes at the beginning of the file, this can easily be done, though, but I'm not sure it's worth it.
Comment 1 Benoit Fouet 2008-06-02 12:40:06 UTC 
Created attachment 111947 [details] [review]
patch for query
Comment 2 Benoit Fouet 2008-06-02 15:46:57 UTC 
oops, forgot one occurence around line 340:

-    block = block_size[mode] + 1;       /* add one for the mode */
+    amrnbparse->block = block_size[mode] + 1;       /* add one for the mode */
Comment 3 Sebastian Dröge (slomo) 2008-06-05 10:20:47 UTC 
Could you attach a combined patch? :)
Comment 4 Benoit Fouet 2008-06-05 11:11:39 UTC 
Created attachment 112203 [details] [review]
combined patch
Comment 5 Wim Taymans 2008-09-26 09:57:26 UTC 
        Patch by: Benoit Fouet <benoit dot fouet at purplelabs dot com>

        * ext/amrnb/amrnbparse.c: (gst_amrnbparse_query),
        (gst_amrnbparse_chain), (gst_amrnbparse_loop),
        (gst_amrnbparse_state_change):
        * ext/amrnb/amrnbparse.h:
        Fix the duration query. Fixes #536226.
        Also set caps on the pads and buffers more correctly.