After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536184 - gtkmm example doesn't build with gcc 4.3
gtkmm example doesn't build with gcc 4.3
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: documentation
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2008-06-02 08:26 UTC by Götz Waschk
Modified: 2008-07-29 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix build (594 bytes, patch)
2008-06-02 08:27 UTC, Götz Waschk 		none Details | Review
fix remaining missing includes (1.50 KB, patch)
2008-06-02 08:51 UTC, Götz Waschk 		none Details | Review
Patch to fix build failure on gcc 4.3 (1.98 KB, patch)
2008-07-29 13:38 UTC, Deng Xiyue 		none Details | Review

Description Götz Waschk 2008-06-02 08:26:35 UTC 
The example custom_widget doesn't build.
Comment 1 Götz Waschk 2008-06-02 08:27:43 UTC 
Created attachment 111931 [details] [review]
fix build

gcc 4.3 is picky, add the missing include.
Comment 2 Götz Waschk 2008-06-02 08:51:23 UTC 
Created attachment 111937 [details] [review]
fix remaining missing includes
Comment 3 Murray Cumming 2008-06-02 09:07:27 UTC 
I wonder, should this be cstring instead of string.h?
Comment 4 Deng Xiyue 2008-07-29 13:38:28 UTC 
Created attachment 115492 [details] [review]
Patch to fix build failure on gcc 4.3

More examples in gtkmm-documentation fails to build upon gcc 4.3.  Patch against svn trunk attached.  Though using <cstring> header, I wonder if we should add "using std::memset;" or something similar as well since IIRC someone reported that on solaris compiler the string functions are not in the global namespace, though the standard allows that and gcc does so.  Not in this patch yet.
Comment 5 Murray Cumming 2008-07-29 13:44:06 UTC 
Thanks. Committed.

>  I wonder if we should add "using std::memset;" or something similar as well 
> since IIRC someone reported that on solaris compiler the string functions are 
> not in the global namespace

I think we should wait for the solaris people to complain about that. It would complicate the example code.