GNOME Bugzilla – Bug 536115
Add a fullscreen browser mode
Last modified: 2018-07-12 00:10:56 UTC
When managing photographs it would be nice if F-Spot could actually use all of my screen when in browser mode.
Created attachment 111914 [details] [review] Fullscreen Browser Patch This patch implements a fullscreen browser mode.Right now it is listed in the "view" menu as Fullscreen and I have reassigned the F11 key to the fullscreen browser. I need a better name for the menu option. One caveat (as noted in the patch) is that when a user quits F-Spot while in fullscreen browser mode and the starts F-Spot back up and exits fullscreen browser mode the window is kept at the screen size rather than getting smaller.
Created attachment 111916 [details] [review] Fullscreen Browser Patch Rename menu option to "Fullscreen Browser" rather than having two Fullscreen options.
Neat & clean, and it works. Good patch! Maybe a bit confusing to have two fullscreen options though. What does the FIXME mean? You're referring to a problem there that I can't reproduce.
Steps to reproduce: 1. Start F-Spot 2. Switch to "Fullscreen Browser" mode 3. Exit F-Spot 4. Start F-Spot (should start in fullscreen browser mode) 5. Switch to regular browser mode 6. Window should now be the same size of the screen. This is most likely window manager specific, so if you are using something other than Compiz, that might explain why you don't see the behavior.
*** Bug 550617 has been marked as a duplicate of this bug. ***
very close to Bug 352008
Comment on attachment 111916 [details] [review] Fullscreen Browser Patch Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this. Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap. Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again. You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
F-Spot has moved to https://github.com/f-spot/f-spot/issues If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub. Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.