After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 535935 - [qtdemux] Missing metadata
[qtdemux] Missing metadata
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-31 16:17 UTC by Bastien Nocera
Modified: 2008-05-31 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Better metadata handling (3.68 KB, patch)
2008-05-31 16:31 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2008-05-31 16:17:50 UTC
In a trailer from the Apple pages:
http://movies.apple.com/movies/independent/the_accidental_husband/the_accidental_husband_h480.mov

One can get extra metadata:
Encoded and delivered by apple.com/trailers/
 2008 All Rights Reserved
In theaters 2008
The Accidental Husband
Comment 1 Bastien Nocera 2008-05-31 16:25:00 UTC
With patch to be attached:
FOUND TAG      : found by element "qtdemux0".
           title: The Accidental Husband
       copyright: © 2008 All Rights Reserved
         comment: Encoded and delivered by apple.com/trailers/
     description: In theaters 2008
Comment 2 Bastien Nocera 2008-05-31 16:31:00 UTC
Created attachment 111851 [details] [review]
Better metadata handling

Problems were:
- this movie doesn't have a meta atom under the udta one
- this movie doesn't use a data atom under the user data list to put its comments
- we didn't handle language codes for the tags that use it

I also added handling for '©cmt' (comment), '©des' (description, undocumented), and '©cpy' (copyright). I tested it with a few non movie files, and it seems to work fine.
Comment 3 Edward Hervey 2008-05-31 16:53:41 UTC
2008-05-31  Edward Hervey  <edward.hervey@collabora.co.uk>

	Patch by: Bastien Nocera <hadess at hadess dot net>
	* gst/qtdemux/qtdemux.c: (qtdemux_tag_add_str),
	(qtdemux_parse_udta):
	* gst/qtdemux/qtdemux_fourcc.h:
	Improve meta-data handling, add 'comment', 'description' and
	'copyright' tag handling.
	Fixes #535935