After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 535908 - use AC_USE_SYSTEM_EXTENSIONS in configure in lieu of AC_ISC_POSIX
use AC_USE_SYSTEM_EXTENSIONS in configure in lieu of AC_ISC_POSIX
Status: RESOLVED FIXED
Product: gamin
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gamin Maintainer(s)
Gamin Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-05-31 12:01 UTC by Dodji Seketeli
Modified: 2008-06-03 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
use AC_USE_SYSTEM_EXTENSIONS instead of AC_ISC_POSIX in configure (558 bytes, patch)
2008-05-31 12:02 UTC, Dodji Seketeli
none Details | Review

Description Dodji Seketeli 2008-05-31 12:01:32 UTC
The AC_ISC_POSIX macro is not deprecated since autoconf 2.6.

Furthermore, using it cause gamin to fail to compile when using glibc-headers 2.8.3 because "struct ucred" defined in /usr/include/bits/socket.h is present only if the __USE_GNU macro is defined.
When the __USE_GNU macro is not defined, libgamin/gam_api.c fails to build at line 715 because struct ucred is not known.
It appears that the AC_ISC_POSIX macro in configure.in does not define the __USE_GNU macro on GNU platforms. The USE_SYSTEM_EXTENSIONS macro is the one to be used now that the AC_ISC_POSIX macro is deprecated. The USE_SYSTEM_EXTENSIONS properly defines the __USE_GNU macro on GNU systems.

I have attached a patch that fixes the problem for me
Comment 1 Dodji Seketeli 2008-05-31 12:02:32 UTC
Created attachment 111844 [details] [review]
use AC_USE_SYSTEM_EXTENSIONS instead of AC_ISC_POSIX in configure
Comment 2 Dodji Seketeli 2008-05-31 12:35:09 UTC
Comment on attachment 111844 [details] [review]
use AC_USE_SYSTEM_EXTENSIONS instead of AC_ISC_POSIX in configure

This patch applies to gamin 0.1.8 btw.
Comment 3 Daniel Veillard 2008-06-03 15:34:55 UTC
Okidoc, applied and commited to SVN,

  thanks !

Daniel