After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 534427 - notify of available wireless network
notify of available wireless network
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
Dan Williams
Depends on:
Blocks:
 
 
Reported: 2008-05-23 01:29 UTC by Colin Walters
Modified: 2008-06-06 01:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
notify on ap availability (9.43 KB, patch)
2008-05-23 01:30 UTC, Colin Walters
none Details | Review
AP notification, cleaner version (7.14 KB, patch)
2008-05-26 21:32 UTC, Colin Walters
none Details | Review
don't crash on new network (7.17 KB, patch)
2008-06-02 17:50 UTC, Colin Walters
none Details | Review

Description Colin Walters 2008-05-23 01:29:20 UTC
Hi, this patch should notify the user in the case where there are available networks, but none of them are autoconnect.

The intended use cases are:

* New user to the system who doesn't know where to click to connect to a network
* Roaming user in a new area gets notified when they have a signal
Comment 1 Colin Walters 2008-05-23 01:30:16 UTC
Created attachment 111377 [details] [review]
notify on ap availability

This patch also adds some machinery to avoid displaced notifications on login; once I figure out how to make it truly robust my plan is to move it into libnotify.
Comment 2 Colin Walters 2008-05-26 21:32:36 UTC
Created attachment 111570 [details] [review]
AP notification, cleaner version

This patch is a lot cleaner - I fixed the libnotify/notification-daemon stuff *right* in a separate patch now sent upstream.

I also fixed some style things (braces on new line), though much of other parts of the code don't seem to do that?
Comment 3 Colin Walters 2008-06-02 17:50:06 UTC
Created attachment 111980 [details] [review]
don't crash on new network

This version of the patch avoids crashing when you actually connect to a new network =)

Another tweak I hope to do soon for this is close the notification when you click on the applet too.
Comment 4 Dan Williams 2008-06-06 01:37:57 UTC
r743