GNOME Bugzilla – Bug 534392
PATCH: never use ffdec_faad
Last modified: 2008-05-26 07:42:39 UTC
When compiling with the included ffmpeg copy, the included copy gets compiled without faad support because this does not work very well atm. The attached patch makes sure that ffdec_faad does not get used even if a system ffmpeg which is compiled with faad support is used. For more on this see: http://bugzilla.livna.org/show_bug.cgi?id=1935 http://bugzilla.gnome.org/show_bug.cgi?id=527389
Created attachment 111360 [details] [review] PATCH: never use ffdec_faad
Looks good but I would've added it to the list in line 2455 ;)
Closing, we don't support issues with gst-ffmpeg built with ffmpeg libraries different from the one we ship. Forward that patch to your distro.
Reopening, I don't agree with this. This patch has nothing to do with system-wide installs. In the words of thaytan: "it explicitly disables something that was only implicitly disabled before".
Created attachment 111394 [details] [review] disable-aac.patch I'd prefer something like this patch though as it's more consistent with the other code around those lines
At Comment #5: the faad codec is named "libfaad".
(In reply to comment #5) > Created an attachment (id=111394) [edit] > disable-aac.patch > > I'd prefer something like this patch though as it's more consistent with the > other code around those lines > Fine by me (if comment #6 is taken into account).
2008-05-26 Sebastian Dröge <slomo@circular-chaos.org> * ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register): Explicitely disable the AAC decoders as they don't work very well and we have better alternatives. Fixes bug #534392.