After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 534392 - PATCH: never use ffdec_faad
PATCH: never use ffdec_faad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
0.10.4
Other Linux
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-22 18:47 UTC by Hans de Goede
Modified: 2008-05-26 07:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
PATCH: never use ffdec_faad (674 bytes, patch)
2008-05-22 19:15 UTC, Hans de Goede
reviewed Details | Review
disable-aac.patch (575 bytes, patch)
2008-05-23 09:55 UTC, Sebastian Dröge (slomo)
none Details | Review

Description Hans de Goede 2008-05-22 18:47:34 UTC
When compiling with the included ffmpeg copy, the included copy gets compiled without faad support because this does not work very well atm.

The attached patch makes sure that ffdec_faad does not get used even if a system ffmpeg which is compiled with faad support is used.

For more on this see:
http://bugzilla.livna.org/show_bug.cgi?id=1935
http://bugzilla.gnome.org/show_bug.cgi?id=527389
Comment 1 Hans de Goede 2008-05-22 19:15:42 UTC
Created attachment 111360 [details] [review]
PATCH: never use ffdec_faad
Comment 2 Sebastian Dröge (slomo) 2008-05-22 20:01:51 UTC
Looks good but I would've added it to the list in line 2455 ;)
Comment 3 Edward Hervey 2008-05-23 09:43:50 UTC
Closing, we don't support issues with gst-ffmpeg built with ffmpeg libraries different from the one we ship.

Forward that patch to your distro.
Comment 4 Wim Taymans 2008-05-23 09:50:40 UTC
Reopening, I don't agree with this. 

This patch has nothing to do with system-wide installs. In the words of thaytan: "it explicitly disables something that was only implicitly disabled before".
Comment 5 Sebastian Dröge (slomo) 2008-05-23 09:55:54 UTC
Created attachment 111394 [details] [review]
disable-aac.patch

I'd prefer something like this patch though as it's more consistent with the other code around those lines
Comment 6 Wim Taymans 2008-05-23 10:07:24 UTC
At Comment #5: the faad codec is named "libfaad".
Comment 7 Hans de Goede 2008-05-23 10:13:37 UTC
(In reply to comment #5)
> Created an attachment (id=111394) [edit]
> disable-aac.patch
> 
> I'd prefer something like this patch though as it's more consistent with the
> other code around those lines
> 

Fine by me (if comment #6 is taken into account).
Comment 8 Sebastian Dröge (slomo) 2008-05-26 07:42:39 UTC
2008-05-26  Sebastian Dröge  <slomo@circular-chaos.org>

        * ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register):
        Explicitely disable the AAC decoders as they don't work very well
        and we have better alternatives. Fixes bug #534392.