Created attachment 111230 [details] [review]
Add Lodz to Locations.xml

Odd... NOAA does have weather information for EPLL, but it doesn't appear in the canonical list of weather stations.... In fact, of the 6096 weather stations that have reported in the last 24 hours, 1/4 of them aren't listed in the station list!?

(In reply to comment #2)
> Odd... NOAA does have weather information for EPLL, but it doesn't appear in
> the canonical list of weather stations.... In fact, of the 6096 weather
> stations that have reported in the last 24 hours, 1/4 of them aren't listed in
> the station list!?

Ah, apparently most of these are ships or offshore oil platforms, which are listed in a separate document, or else they're classified military locations and we're not supposed to know where they are. :-)

There are still a few hundred real ones like EPLL that we're missing though.

Committed the patch for Lodz. I'm leaving the bug open because of the larger issue.

Created attachment 130017 [details] [review]
re-fix for lodz

This got broken with the Locations.xml.in rewrite. Too late to fix now for 2.26 (string freeze)

*** Bug 578885 has been marked as a duplicate of this bug. ***

Committed as d925141

as noted in comment #4, the larger issue still needs to be addressed

This broke the string freeze.
Please revert or branch.

Oh, did it? I'm so sorry. I really thought we're out of that for weeks. I'm reverting the patch: 02cead8
I'm also resetting the status to accept-commit_after_freeze.

We are out of a freeze for a module when the module has branched.
String freeze is forever in a stable series.

Committing the patch again to development branch. The fix will be available in the next major software release shortly. Thank you for your bug report.

Re-opening for the larger issue mentioned above

I've re-removed Lodz airport, as it doesn't export weather information anymore.

commit e30ae4b63017a72a145ccf4b394a039e3239fd9a
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Dec 13 14:26:45 2017 +0100

    locations: Remove Łódź airport
    
    It no longer provides METAR information.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=534047

As for weather stations not being listed but being used, I don't think we have a canonical database for it. I've added a regression test that checks whether a weather station is listed in https://www.aviationweather.gov/docs/metar/stations.txt and I've had good luck trimming/replacing obsolete weather stations using that.

If somebody has a better idea of how to handle this, please file a new bug.

Marking as FIXED as Lodz was added to the database.

How do you check if an airport exports weather information? According to <http://en.allmetsat.com/metar-taf/poland.php?icao=EPLL>, Łódź-Lublinek still does.

Using the same URL libgweather uses:
$ wget -O- -q "https://www.aviationweather.gov/adds/dataserver_current/httpparam?dataSource=metars&requestType=retrieve&format=xml&hoursBeforeNow=24&mostRecent=true&fields=raw_text&stationString=EPLL"
<?xml version="1.0" encoding="UTF-8"?>
<response xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XML-Schema-instance" version="1.2" xsi:noNamespaceSchemaLocation="http://aviationweather.gov/adds/schema/metar1_2.xsd">
  <request_index>194375552</request_index>
  <data_source name="metars" />
  <request type="retrieve" />
  <errors>
    <error>Invalid field name(s) found: raw_text</error>
  </errors>
  <warnings />
  <time_taken_ms>0</time_taken_ms>
</response>

But, I ran it again and:
$ wget -O- -q "https://www.aviationweather.gov/adds/dataserver_current/httpparam?dataSource=metars&requestType=retrieve&format=xml&hoursBeforeNow=24&mostRecent=true&fields=raw_text&stationString=EPLL"
<?xml version="1.0" encoding="UTF-8"?>
<response xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XML-Schema-instance" version="1.2" xsi:noNamespaceSchemaLocation="http://aviationweather.gov/adds/schema/metar1_2.xsd">
  <request_index>76331972</request_index>
  <data_source name="metars" />
  <request type="retrieve" />
  <errors />
  <warnings />
  <time_taken_ms>6</time_taken_ms>
  <data num_results="1">
    <METAR>
      <raw_text>EPLL 131500Z 13004KT CAVOK 01/M03 Q1012</raw_text>
    </METAR>
  </data>
</response>

I'll revert that patch I guess. I have no idea what this error means...

Thank you!