After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 533865 - gst_element_get_pad() should really be deprecated
gst_element_get_pad() should really be deprecated
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-19 13:35 UTC by Murray Cumming
Modified: 2012-09-03 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Murray Cumming 2008-05-19 13:35:34 UTC 
The gst_element_get_pad() documentation says 
"Usage of this function is not recommended as it is unclear if the reference to the result pad should be released"
in
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstElement.html#gst-element-get-pad

So this function is obviously completely broken. If it can't be made consistent then it should be properly deprecated, with advice about what to use instead.
Comment 1 Sebastian Dröge (slomo) 2008-05-29 07:19:22 UTC 
2008-05-29  Sebastian Dröge  <slomo@circular-chaos.org>

        * gst/gstelement.c:
        * gst/gstelement.h:
        Deprecated gst_element_get_pad() as it can't be used sanely. It's not
        clear of the reference to the resulting pad must be released later
        or not, resulting in possible leaks. Fixes bug #533865.
Comment 2 Dominique Leuenberger 2012-09-03 15:56:30 UTC 
So... the depreciation happened, the 'advise' what to use instead though was missing, which makes porting code more difficult (it was dropped from 0.11/1.0 if I see this right).