Bug 533516 – Crash in value_intersection()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 533516 - Crash in value_intersection()


Summary:	Crash in value_intersection()


Status:	RESOLVED FIXED

Product:	Gnumeric
Classification:	Applications
Component:	Analytics
Version:	git master
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Morten Welinder
QA Contact:	Jody Goldberg

URL:
Whiteboard:

Duplicates:	559760 (view as bug list)
Depends on:
Blocks:

Reported:	2008-05-17 06:44 UTC by sum1
Modified:	2008-11-07 15:40 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
fixes the crash (431 bytes, patch) 2008-05-17 14:28 UTC, Jean Bréfort	none	Details \| Review

Description sum1 2008-05-17 06:44:22 UTC

Version: r16575
OS: Ubuntu Hardy

Steps to reproduce:
- Enter '+{}' (no quotes) into A1

Backtrace:
Program received signal SIGSEGV, Segmentation fault.

+ Trace 197932

Thread 3061881440 (LWP 23925)

#0 value_intersection
at expr.c line 648
#1 gnm_expr_eval
at expr.c line 1368
#2 gnm_expr_top_eval
at expr.c line 2837
#3 gnm_cell_eval_content
at dependent.c line 1450
#4 gnm_rendered_value_new
at rendered-value.c line 210
#5 gnm_cell_render_value
at cell.c line 469
#6 row_calc_spans
at cellspan.c line 411
#7 sheet_range_bounding_box
at sheet.c line 2250
#8 scg_redraw_range
at sheet-control-gui.c line 147
#9 sc_redraw_range
at sheet-control.c line 89
#10 sheet_redraw_partial_row
at sheet.c line 1010
#11 sheet_cell_calc_span
at sheet.c line 1102
#12 sheet_cell_set_text
at sheet.c line 2144
#13 cmd_set_text_redo
at commands.c line 851
#14 command_push_undo
at commands.c line 742
#15 cmd_set_text
at commands.c line 1030
#16 wbcg_edit_finish
at wbc-gtk-edit.c line 222
#17 cb_gee_key_press_event
at gnumeric-expr-entry.c line 507

Comment 1 Jean Bréfort 2008-05-17 14:05:48 UTC

={} gives the same issue

Comment 2 Jean Bréfort 2008-05-17 14:28:46 UTC

Created attachment 111048 [details] [review]
fixes the crash

We should always check that the array size is large enough, there might be other such issues.
I'm not sure that #NULL is the correct error in that specific case

Comment 3 Morten Welinder 2008-05-17 22:23:37 UTC

Looks good.  For good measure we need to return the same error message
as Excel, so please wait until we can verify what exactly that is.

Comment 4 Morten Welinder 2008-05-19 13:19:58 UTC

Excel rejects the formula on entry.

Comment 5 Morten Welinder 2008-05-19 20:47:25 UTC

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.


I picked #VALUE instead -- nothing appears to use NULL, except a few dubious
places.

Comment 6 stefano frangioni 2008-11-07 15:40:06 UTC

*** Bug 559760 has been marked as a duplicate of this bug. ***