GNOME Bugzilla – Bug 533287
Mapping of mime types to gst names in multipartdemux
Last modified: 2009-03-05 19:41:58 UTC
The multipartdemuxer uses the mime type as gst name on the src pad. This is not always desirable, sometimes another name is required. I have made it possible to make a mapping between a mime type and a different gst name. I have added one such mapping : mime type audio/basic -> gst name audio/x-mulaw. It can be noted that this functionality already exists in the multipartmuxer, i.e. it can map a gst name do a different mime type. The functionality is implemented in gst/multipart/multipartdemux.c gst/multipart/multipartdemux.h CVS diffs are included in the attachements
Created attachment 110953 [details] [review] cvs diff showing the changes needed for multipartdemux.c
Created attachment 110954 [details] [review] cvs diff showing the changes needed for multipartdemux.h
I modified it a little to handle the conversion a little earlier. Please test again. Patch by: Patrick Radizi <patrick dot radizi at axis dot com> * gst/multipart/multipartdemux.c: (gst_multipart_demux_class_init), (gst_multipart_demux_get_gstname), (gst_multipart_find_pad_by_mime), (gst_multipart_demux_chain): * gst/multipart/multipartdemux.h: Don't blindly copy the mime-type as the caps name because they not always map directly. Instead use a hashtable with common mappings. Fixes #533287.
I tested the latest change and it works fine.
Created attachment 130143 [details] [review] proxy patch for gst-plugins-base
Created attachment 130144 [details] [review] proxy patch for gst-plugins-good
Ignore comments/attachements #5,#6. I added these in the wrong report, they belong to #573173 :-( Is there no way to undo/remove a comment ?
I rejected them.