After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 533264 - Make v4l2 compile without X
Make v4l2 compile without X
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-15 11:11 UTC by Damien Lespiau
Modified: 2008-05-17 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Include xoverlay headers if USE_XVIDEO is defined (999 bytes, patch)
2008-05-15 11:12 UTC, Damien Lespiau 		rejected Details | Review

Description Damien Lespiau 2008-05-15 11:11:34 UTC 
Right now, the v4l2 plugin includes unconditionally XV headers even if you specify --disable-xvideo on the configure line.

This can be a problem for hosts that don't have X (think embedded here) and that do want to use v4l2src.

The patch joined here should fix that.
Comment 1 Damien Lespiau 2008-05-15 11:12:44 UTC 
Created attachment 110950 [details] [review]
Include xoverlay headers if USE_XVIDEO is defined
Comment 2 Sebastian Dröge (slomo) 2008-05-17 10:29:33 UTC 
This patch needs some work... the xoverlay functions are used in the source files and this usage should be made conditional too then. Otherwise stuff stil won't build.
Comment 3 Sebastian Dröge (slomo) 2008-05-17 10:38:05 UTC 
Nevermind, the xoverlay stuff isn't even implemented yet properly and latest CVS has it disabled everywhere... it only includes the header at a single place while it shouldn't. Fixed now ;)

2008-05-17  Sebastian Dröge  <slomo@circular-chaos.org>

        * sys/v4l2/gstv4l2src.c:
        Don't include the gstv4l2xoverlay.h header as the XOverlay support
        isn't implemented at all yet and this requires X headers to be
        installed. Fixes bug #533264.