GNOME Bugzilla – Bug 533218
Should try to locate correct album (and download its cover) in case no album name is supplied on metadata
Last modified: 2020-03-17 08:19:29 UTC
I plan to hack on this. When no album is found on metadata, Banshee tries to fetch something like: http://musicbrainz.org/ws/1/release/?type=xml&artist=Eurythmics&title=Unknown%20Album Instead of: http://musicbrainz.org/ws/1/track/?type=xml&title=Sweet%20Dreams&artist=Eurythmics
Created attachment 111115 [details] [review] Proposed patch I've tested it and it works. However it depends on the patch I proposed on bug 499650 (indeed bug 528493).
Created attachment 111117 [details] [review] New patch In the old one there was a change in MusicBrainzQueryJob.cs which was not needed.
I don't like the idea of having an extra *Guessed property in TrackInfo - I'd much much rather have a tool that helps you fix your AlbumTitle (eg maybe within the Track Editor or a new dialog) than this. Such a tool would be very neat (could 'guess'/fill in all sorts of info based on just a little input or guesswork). This also shouldn't have anything to do w/ cover art. The way I see it, this should either be closed as INVALID or as a dupe of bug #523423.
Hey Gabriel, (In reply to comment #3) > I don't like the idea of having an extra *Guessed property in TrackInfo - I'd > much much rather have a tool that helps you fix your AlbumTitle (eg maybe > within the Track Editor or a new dialog) than this. Such a tool would be very > neat (could 'guess'/fill in all sorts of info based on just a little input or > guesswork). This also shouldn't have anything to do w/ cover art. Agreed that such a tool would be handy, but I think it should be optional, right? What I mean is, what about this use case?: 1. Song without album metadata starts to play. 2. User puts the mouse over the icon. Current results: Nothing happens. Expected results: Banshee should try to guess the album name since it has the rest of the metadata (song name and artist) and it has some metadata providers. Then Banshee would show the album to the user like if the metadata was there, *and* include a small label and button with the text and caption "Album metadata was not present on the song. [Save this album name]" Do you like this better? Anyway, this bugs depends on another bug (bug 528493) which contains a patch, so could you review the patch there in order to rework my patch here if you like this new approach? Thanks very much dude.
*** Bug 663319 has been marked as a duplicate of this bug. ***
As the other bug is closed now, this one could be looked at again.
Hey Samuel, thanks for your interest! I plan looking at this soon again, but not before Banshee 2.4.0 is released (because right now we're in bug-fixing phase, no new features allowed as 2.3.6 is the last development version in the 2.3.x dev series).
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.