GNOME Bugzilla – Bug 533198
add config option for legacy sound, always enable pulseaudio
Last modified: 2008-06-17 18:38:46 UTC
Hi, this attached patch changes gnome-settings-daemon to ignore the legacy ESD GConf preference if compiled to use Pulseaudio; we just always start pulse. This fixes the issue where if a user had disabled ESD because it caused problems, on later upgrades pulse wouldn't be started, which isn't desired. This should have never been in GConf anyways, it isn't a preference. We'll be using this patch in Fedora.
Created attachment 110935 [details] [review] check for pulse at build time, disable sound preferences
I'm not sure we want to do that. PA may be better, but as long as we have a preference in the UI saying "start sound server" (and we can't really get rid of that until esd is thoroughly dead - and even then I'm not sure we want to; if PA worked flawlessly, yeah; does it? probably not (yet)) it's just calling for a different kind of bug report. (Ignoring for the moment that adding an option for enabling an option seems like... not much better than esd.)
Fedora disables that UI preference, and I would like to see that patch upstreamed. Remember that the option we're adding here is a *code* option. It's used by operating system developers once. It is an option to disable a *user* option, which is only useful if you're using ESD.
Agreed there, and the patch looks sane.
Thanks for the review! Sending ChangeLog Sending configure.ac Sending plugins/sound/gsd-sound-manager.c Transmitting file data ... Committed revision 379.