After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 532965 - Should not return filesystem::free for certain file systems
Should not return filesystem::free for certain file systems
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: Alexander Larsson
gtkdev
: 531743 (view as bug list)
Depends on:
Blocks: 531743
 
 
Reported: 2008-05-13 14:53 UTC by A. Walton
Modified: 2008-05-17 06:08 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Christian Neumair's Patch (905 bytes, patch)
2008-05-15 05:07 UTC, A. Walton
committed Details | Review

Description A. Walton 2008-05-13 14:53:55 UTC
Discussed here:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/224760

For filesystems which don't return remaining free space, such as NCPFS, GIO should not propagate the filesystem::free attribute, so that applications that check for free space on the device before an action is taken, like Nautilus, will not erroneously bail out due to lack of free space on the device.
Comment 1 Matthias Clasen 2008-05-15 05:02:34 UTC
I'll review the patch when it makes its way here from the downstream bug...
Comment 2 A. Walton 2008-05-15 05:07:18 UTC
Created attachment 110940 [details] [review]
Christian Neumair's Patch

Oops, I meant to do this after I filed the bug. No idea if it works or is correct though, don't have the filesystem to check.
Comment 3 Matthias Clasen 2008-05-15 05:10:38 UTC
you could make it report no size for, say, ext3, and check the mechanics of the patch that way...
Comment 4 Christian Neumair 2008-05-16 15:45:44 UTC
Matthias: It's quite obvious that it should work. However, I wanted to check whether the magic really matches the ncpfs magic [even if reading headers suggests that], you never know the oddities of real-world scenarios.

Various Ubuntu users confirm that the patch fixes the issue for them.
Comment 5 Christian Neumair 2008-05-16 15:46:46 UTC
*** Bug 531743 has been marked as a duplicate of this bug. ***
Comment 6 Matthias Clasen 2008-05-17 05:15:41 UTC
thanks for the update