GNOME Bugzilla – Bug 532965
Should not return filesystem::free for certain file systems
Last modified: 2008-05-17 06:08:22 UTC
Discussed here: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/224760 For filesystems which don't return remaining free space, such as NCPFS, GIO should not propagate the filesystem::free attribute, so that applications that check for free space on the device before an action is taken, like Nautilus, will not erroneously bail out due to lack of free space on the device.
I'll review the patch when it makes its way here from the downstream bug...
Created attachment 110940 [details] [review] Christian Neumair's Patch Oops, I meant to do this after I filed the bug. No idea if it works or is correct though, don't have the filesystem to check.
you could make it report no size for, say, ext3, and check the mechanics of the patch that way...
Matthias: It's quite obvious that it should work. However, I wanted to check whether the magic really matches the ncpfs magic [even if reading headers suggests that], you never know the oddities of real-world scenarios. Various Ubuntu users confirm that the patch fixes the issue for them.
*** Bug 531743 has been marked as a duplicate of this bug. ***
thanks for the update