After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 532807 - [rmdemux] Doesn't properly aggregate flow returns
[rmdemux] Doesn't properly aggregate flow returns
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal blocker
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-12 16:43 UTC by Edward Hervey
Modified: 2008-05-13 09:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't override flow returns from downstream (751 bytes, patch)
2008-05-12 16:43 UTC, Edward Hervey 		needs-work Details | Review
improved patch, should react faster/better (1.14 KB, patch)
2008-05-13 09:05 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2008-05-12 16:43:10 UTC 
Currently rmdemux doesn't properly aggregate flow return values from downstream elements.

Follows a patch to fix the issue.
Comment 1 Edward Hervey 2008-05-12 16:43:39 UTC 
Created attachment 110783 [details] [review]
Don't override flow returns from downstream
Comment 2 Sebastian Dröge (slomo) 2008-05-13 07:20:22 UTC 
Looks at least more correct than before to me but shouldn't the flow return be checked after each pushed buffer to handle errors more instant instead of just pushing more and more buffers and just taking the last flow return?

One case that comes to my mind where the current behaviour is, when all except one pad are linked and the last buffer that is pushed is pushed to the unlinked one. In that case we will error out with GST_FLOW_NOT_LINKED instead of just continuing.

So, IMHO this patch needs some more work
Comment 3 Edward Hervey 2008-05-13 09:05:25 UTC 
Created attachment 110836 [details] [review]
improved patch, should react faster/better
Comment 4 Edward Hervey 2008-05-13 09:33:33 UTC 
2008-05-13  Edward Hervey  <edward.hervey@collabora.co.uk>

	* gst/realmedia/rmdemux.c: (gst_rmdemux_parse_video_packet):
	Properly aggregate GstFlowReturn from downstream in order to properly
	stop, and doing that as early as possible.
	Fixes #532807