After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 532475 - middle-click drag a path bar button
middle-click drag a path bar button
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.22.x
Other Linux
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-10 12:46 UTC by Sebastien Bacher
Modified: 2008-08-01 12:47 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
proposed patch (4.24 KB, patch)
2008-05-12 17:59 UTC, Cosimo Cecchi
needs-work Details | Review
proposed patch v2 (4.26 KB, patch)
2008-05-19 13:10 UTC, Cosimo Cecchi
none Details | Review

Description Sebastien Bacher 2008-05-10 12:46:08 UTC
the bug has been opened on https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/228213

"When in browser mode, you can drag a button on the path bar to copy the folder it represents. It would be useful to be able to middle-drag it too, to get the same options you get when you middle-click drag a folder."
Comment 1 Cosimo Cecchi 2008-05-12 17:59:32 UTC
Created attachment 110790 [details] [review]
proposed patch

Complete the DnD implementation for buttons on pathbar. This is done in the same way we do it for the spatial window location selector.
Comment 2 Christian Neumair 2008-05-19 12:37:22 UTC
Thanks for your efforts!

Improving the button bar experience is a very important task.

The approach looks fine too, but you should use gtk_widget_get_ancestor() on the button_data's button instead of storing a link to the GUI widget in ButtonData.
Comment 3 Cosimo Cecchi 2008-05-19 13:10:06 UTC
Created attachment 111156 [details] [review]
proposed patch v2

Christian, thanks for the review. I updated the patch according to your comment.
Comment 4 Cosimo Cecchi 2008-07-24 14:05:28 UTC
Christian already committed a similar patch to trunk some time ago, so we were just lacking GDK_BUTTON2_MASK in the gtk_drag_source_set () call to make this work.

2008-07-24  Cosimo Cecchi  <cosimoc@gnome.org>

	* src/nautilus-pathbar.c: (setup_button_drag_source):
	Enable middle-click dragging a path bar button (#532475).
Comment 5 David Prieto 2008-07-28 16:50:16 UTC
Hi and thanks for all your efforts,

I have been using the latest Ubuntu Intrepid daily iso to test this new feature, (it appears as "fix released" in Launchpad) but the functionality still seems to be missing.

I can drag pathbar buttons with the left button alright, even press the ctrl / shift keys to copy / move, but using the middle button to drag seems to have no effect at all.

The iso I'm using might, in fact, be two or three days old but if definitely should sport this feature. Are you positive that middle-dragging a pathbar button gives you a menu now?
Comment 6 Pedro Villavicencio 2008-08-01 12:47:49 UTC
David, Ubuntu Intrepid has nautilus 2.23.5.1 (current nautilus dev version) which doesn't contain the fix you might want to wait for the next nautilus release or try the trunk version, thanks you.