After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 532409 - RTP payload/depayloader for G.729
RTP payload/depayloader for G.729
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal major
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-09 21:32 UTC by Olivier Crête
Modified: 2009-01-23 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
payloader/depayloader for G.729 (4.08 KB, application/x-compressed-tar)
2008-05-09 21:34 UTC, Olivier Crête 		  Details
Patch fixing the G729 payloader for current CVS (14.16 KB, patch)
2008-11-11 17:18 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2008-05-09 21:32:53 UTC 
I'm attaching RTP pay/depay for G.729 that are currently part of gst-plugins-farsight. They're currently used by OS2007.x and OS2008 and have been extensively tested.
Comment 1 Olivier Crête 2008-05-09 21:34:03 UTC 
Created attachment 110664 [details]
payloader/depayloader for G.729
Comment 2 Wim Taymans 2008-05-13 08:33:22 UTC 
        Based on patch by: Olivier Crete <tester at tester dot ca>

        * gst/rtp/Makefile.am:
        * gst/rtp/gstrtp.c: (plugin_init):
        * gst/rtp/gstrtpg729depay.c: (gst_rtp_g729_depay_base_init),
        (gst_rtp_g729_depay_class_init), (gst_rtp_g729_depay_init),
        (gst_rtp_g729_depay_setcaps), (gst_rtp_g729_depay_process),
        (gst_rtp_g729_depay_plugin_init):
        * gst/rtp/gstrtpg729depay.h:
        * gst/rtp/gstrtpg729pay.c: (gst_rtpg729pay_base_init),
        (gst_rtpg729pay_class_init), (gst_rtpg729pay_init),
        (gst_rtpg729pay_setcaps), (gst_rtp_g729_pay_plugin_init):
        * gst/rtp/gstrtpg729pay.h:
        Added G729 pay and depayloaders. Fixes #532409.
Comment 3 Olivier Crête 2008-11-11 17:15:24 UTC 
When you added the RTP payloader, you noobed it.
G729 frames are not always the same size, they can be CN frames, in that case, they are only 2 bytes. So GstBaseRTPAudioPay isn't suitable.

Please replace the current payloader with the one attached to this bug which actually works.
Comment 4 Olivier Crête 2008-11-11 17:18:54 UTC 
Created attachment 122434 [details] [review]
Patch fixing the G729 payloader for current CVS
Comment 5 Wim Taymans 2008-11-11 17:29:18 UTC 
        Patch by: Olivier Crete <tester at tester dot ca>

        * gst/rtp/gstrtpg729pay.c: (gst_rtp_g729_pay_base_init),
        (gst_rtp_g729_pay_class_init), (gst_rtp_g729_pay_init),
        (gst_rtp_g729_pay_set_caps), (gst_rtp_g729_pay_handle_buffer):
        * gst/rtp/gstrtpg729pay.h:
        Replace G729 payloader with an improved version. Fixes #532409.