After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 532210 - src/tools/analysis-tools.c cleanup
src/tools/analysis-tools.c cleanup
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Analytics
git master
Other All
: Normal normal
: ---
Assigned To: Morten Welinder
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-05-08 17:48 UTC by Morten Welinder
Modified: 2008-05-14 01:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patchable patch (25.12 KB, patch)
2008-05-08 17:48 UTC, Morten Welinder
none Details | Review
Readable patch (21.22 KB, patch)
2008-05-08 17:49 UTC, Morten Welinder
none Details | Review
Updated patchable patch (27.97 KB, patch)
2008-05-10 15:00 UTC, Morten Welinder
none Details | Review

Description Morten Welinder 2008-05-08 17:48:18 UTC
Proposed patch for cleaning up analysis-tools.c coming up shortly
in two versions: patchable, and ignore-whitespace for readability.

The patch introduces a helper function for making relative references.
That way we do not have to depend on the order of structure fields.

Note, that a few gnm_expr_new_cellref are left in cases where we
explicitly set a sheet for the references.  I do not see a good
reason for doing that, but we do.

Comments, please.
Comment 1 Morten Welinder 2008-05-08 17:48:43 UTC
Created attachment 110594 [details] [review]
Patchable patch
Comment 2 Morten Welinder 2008-05-08 17:49:06 UTC
Created attachment 110595 [details] [review]
Readable patch
Comment 3 Andreas J. Guelzow 2008-05-09 04:04:41 UTC
The patch looks good to me.

And there is really no reason why I (?) set the sheet in the single ANOVA. That is clearly unnecessary. 

Comment 4 Morten Welinder 2008-05-10 15:00:52 UTC
Created attachment 110680 [details] [review]
Updated patchable patch

This handled the remaining cases too.

I wish we had a way to test these tools like we do for goal-seek,
i.e., a hidden option for ssconvert to run the tools.
Comment 5 Andreas J. Guelzow 2008-05-10 15:33:43 UTC
This looks good to me. Please commit. 
Comment 6 Morten Welinder 2008-05-14 01:46:59 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.