GNOME Bugzilla – Bug 532210
src/tools/analysis-tools.c cleanup
Last modified: 2008-05-14 01:46:59 UTC
Proposed patch for cleaning up analysis-tools.c coming up shortly in two versions: patchable, and ignore-whitespace for readability. The patch introduces a helper function for making relative references. That way we do not have to depend on the order of structure fields. Note, that a few gnm_expr_new_cellref are left in cases where we explicitly set a sheet for the references. I do not see a good reason for doing that, but we do. Comments, please.
Created attachment 110594 [details] [review] Patchable patch
Created attachment 110595 [details] [review] Readable patch
The patch looks good to me. And there is really no reason why I (?) set the sheet in the single ANOVA. That is clearly unnecessary.
Created attachment 110680 [details] [review] Updated patchable patch This handled the remaining cases too. I wish we had a way to test these tools like we do for goal-seek, i.e., a hidden option for ssconvert to run the tools.
This looks good to me. Please commit.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.