After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 532072 - brasero is not able to generate iso image when long localized label is used
brasero is not able to generate iso image when long localized label is used
Status: RESOLVED FIXED
Product: l10n
Classification: Infrastructure
Component: Russian [ru]
git master
Other All
: Normal major
: ---
Assigned To: Dmitry G. Mastrukov
Dmitry G. Mastrukov
Depends on:
Blocks:
 
 
Reported: 2008-05-07 23:51 UTC by Gregory Petrosyan
Modified: 2008-06-15 18:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
untested patch (1.98 KB, patch)
2008-05-07 23:55 UTC, Gregory Petrosyan
none Details | Review
shorter russian default disk labels (to fit in 32 bytes limit) (568 bytes, patch)
2008-05-08 00:10 UTC, Gregory Petrosyan
none Details | Review

Description Gregory Petrosyan 2008-05-07 23:51:43 UTC
Please describe the problem:
https://bugs.launchpad.net/ubuntu/+source/brasero/+bug/220312

Steps to reproduce:
Run brasero and compose data project.
1. Press Burn...
2. Fill in completely the "Label of the disc" field with some localized string (I used Russian)

Actual results:
After making a checksum brasero will choke with an error message. The log clearly indicates the source of the problem:
"BraseroGenisoimage stderr: /usr/bin/genisoimage: Volume ID string too long"

Expected results:


Does this happen every time?
yes

Other information:
Comment 1 Gregory Petrosyan 2008-05-07 23:55:45 UTC
Created attachment 110556 [details] [review]
untested patch

(this patch has been sent to the brasero-list@gnome.org; message-id <6306f97b0805071628t6b1e0cds31313e35cc3c8983@mail.gmail.com>)

As I see it, the problem is that label edit box is limited to 32 _characters_, not bytes.
This patch does 2 things:
- ensure that brasero_disc_option_dialog_get_default_label returns valid label
- make brasero_disc_option_dialog_set_label truncate long labels
 (I am not sure if g_utf8_find_prev_char-based approach is ok here)
Comment 2 Gregory Petrosyan 2008-05-08 00:10:03 UTC
Created attachment 110557 [details] [review]
shorter russian default disk labels (to fit in 32 bytes limit)
Comment 3 Gregory Petrosyan 2008-05-08 00:10:57 UTC
Comment on attachment 110557 [details] [review]
shorter russian default disk labels (to fit in 32 bytes limit)

other languages may need similar fixes
Comment 4 Philippe Rouquier 2008-05-12 09:26:09 UTC
Thanks for the report and the patch.
As for the patch I modified it since it didn't take into account the cursor position and always removed the last characters of the label.
Anyway, thanks again for the patch. It is fixed in trunk.

NOTE: as for the translation I'm not supposed to change them since I'm just the developer so you should send them to the Russian coordinator (dmitry@taurussoft.org). If he doesn't answer, I'll do it myself but please try it with him first.
Comment 5 Nickolay V. Shmyrev 2008-06-02 20:05:49 UTC
Philippe: actually it's better just to reassign bug than use mail
Comment 6 Philippe Rouquier 2008-06-04 20:00:13 UTC
OK, Sorry about that.
Comment 7 Nickolay V. Shmyrev 2008-06-04 20:19:57 UTC
No problem really, it's our fault so we must apologize.
Comment 8 Nickolay V. Shmyrev 2008-06-15 18:25:16 UTC
Fixed in trunk