After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 531562 - -Wformat breaks builds
-Wformat breaks builds
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Builds
0.x.x [obsolete]
Other Linux
: Normal normal
: ---
Assigned To: A. Walton
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-05 15:02 UTC by A. Walton
Modified: 2008-05-05 19:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix it! (1.71 KB, patch)
2008-05-05 15:02 UTC, A. Walton 		committed Details | Review

Description A. Walton 2008-05-05 15:02:30 UTC 
Discovered with the Ibex toolchain (where -Wformat is used by default); we've got a few strings missing their proper format string, which breaks the build. Following is a patch to fix these issues.
Comment 1 A. Walton 2008-05-05 15:02:59 UTC 
Created attachment 110409 [details] [review]
fix it!
Comment 2 Cosimo Cecchi 2008-05-05 19:17:27 UTC 
This seems pretty straightforward, so go for it!
Comment 3 A. Walton 2008-05-05 19:22:37 UTC 
Thanks for the review, committed:

2008-05-05  A. Walton  <awalton@gnome.org>

	reviewed by: Cosimo Cecchi

	* libnautilus-private/nautilus-module.c (nautilus_module_load):
	* src/file-manager/fm-ditem-page.c (save_entry):
	* src/nautilus-autorun-software.c (autorun):
	Fixes build on toolchains with -Wformat enabled. 
	Closes bug #531562.